Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported datamap cache hotfix #3222

Merged
merged 7 commits into from
May 9, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented May 4, 2023

Closes #3213

Code Changes

  • Create new mergeColumns function that handles combining the cached columns with the new columns
  • Invalidate the Datamap RTK cache when custom fields are created, edited, and deleted

Steps to Confirm

  • Visit the datamap page so the column settings get cached
  • Go create a new custom field
  • create a system and populate the custom field with data
  • visit the datamap table and open the settings modal. The new custom field should be in the listed columns. NOTE: it won't show up if no system is using the column
  • Go back and edit the name of the custom field
  • Visit the datamap table again and check the settings modal. The column should be in the modal with the new name. It will most likely be at the bottom. That is expected.

Pre-Merge Checklist

Description Of Changes

This fixes the same issue that #3211 fixed. The fix was duplicated because the recent work with the RTK APIs conflicted with what was needed in the release branch. The RTK API update was great for this btw @allisonking. It helped a lot with invalidating the Datamap cache when custom fields are updated.

@TheAndrewJackson TheAndrewJackson self-assigned this May 4, 2023
@cypress
Copy link

cypress bot commented May 4, 2023

Passing run #1792 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 5a79965 into b5b1649...
Project: fides Commit: f26e3808e1 ℹ️
Status: Passed Duration: 00:49 💡
Started: May 5, 2023 9:43 PM Ended: May 5, 2023 9:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review May 4, 2023 17:53
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, those tests look great, thanks for adding them!

@TheAndrewJackson TheAndrewJackson merged commit 5c75e86 into main May 9, 2023
@TheAndrewJackson TheAndrewJackson deleted the backported_datamap_cache_hotfix branch May 9, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datamap table doesn't show new columns in table or settings modal
2 participants