-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backported datamap cache hotfix #3222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1792 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
allisonking
reviewed
May 4, 2023
allisonking
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay, those tests look great, thanks for adding them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3213
Code Changes
mergeColumns
function that handles combining the cached columns with the new columnsDatamap
RTK cache when custom fields are created, edited, and deletedSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This fixes the same issue that #3211 fixed. The fix was duplicated because the recent work with the RTK APIs conflicted with what was needed in the release branch. The RTK API update was great for this btw @allisonking. It helped a lot with invalidating the
Datamap
cache when custom fields are updated.