Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - merge cached datamap settings with new data #3211

Merged
merged 3 commits into from
May 4, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented May 3, 2023

Closes #3212

Code Changes

  • Create new mergeColumns function that handles combining the cached columns with the new columns

Steps to Confirm

  • Visit the datamap page so the column settings get cached
  • Go create a new custom field
  • create a system and populate the custom field with data
  • visit the datamap table and open the settings modal. The new custom field should be in the listed columns. NOTE: it won't show up if no system is using the column
  • Go back and edit the name of the custom field
  • Visit the datmamp table again and check the settings modal. The column should be in the modal with the new name. It will most likely be at the bottom. That is expected.

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@TheAndrewJackson TheAndrewJackson changed the title merge Cache with new data Hotfix - merge cached datamap settings with new data May 3, 2023
@TheAndrewJackson TheAndrewJackson self-assigned this May 3, 2023
@cypress
Copy link

cypress bot commented May 3, 2023

Passing run #1760 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge e4d2ab5 into e917207...
Project: fides Commit: 2bf53d6ccc ℹ️
Status: Passed Duration: 01:05 💡
Started: May 4, 2023 3:31 PM Ended: May 4, 2023 3:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson changed the base branch from release-2.12.0 to release-2.12.1 May 4, 2023 14:49
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review May 4, 2023 15:37
@adamsachs
Copy link
Contributor

this is looking really good to me in some manual testing locally! things get updated seamlessly as far as i can tell.

i happened to notice a BE regression in doing testing for this, i'll file/follow up with that separately.

@TheAndrewJackson TheAndrewJackson merged commit 2635b49 into release-2.12.1 May 4, 2023
@TheAndrewJackson TheAndrewJackson deleted the hotfix_datamap_settings_cache branch May 4, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants