Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dezone and bring nav back #2990

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Apr 4, 2023

Closes #2977

Code Changes

  • Restore the nav-config from fidesui
  • Update constant route paths throughout the app (most of the changes are from here)
  • Remove zones and fix all the interzone navs to just navigate to the same zone ☺️

Steps to Confirm

  • npm run dev
  • Now you should be able to click on "Data map" and be brought to localhost:3000/datamap which has the admin ui's version of the datamap

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@@ -0,0 +1,14 @@
import { useFeatures } from "~/features/common/features";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a simplified version of useInterzoneNav

@cypress
Copy link

cypress bot commented Apr 4, 2023

Passing run #1159 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge d02ecc4 into 916a234...
Project: fides Commit: 6d76821efd ℹ️
Status: Passed Duration: 00:38 💡
Started: Apr 4, 2023 8:09 PM Ended: Apr 4, 2023 8:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review April 4, 2023 20:19
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and is much simpler than what we had before 😅 It's great to have one next app. I think I clicked around all of the links and everything worked as expected.

Taking a look at #2992 now 👀

@allisonking allisonking merged commit 00c5242 into aking/2975/copy-in-datamap-ui Apr 5, 2023
@allisonking allisonking deleted the aking/2977/dezone-and-bring-nav-back branch April 5, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants