Fix layout of datamap page #2992
Conversation
Passing run #1164 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
There was a problem hiding this comment.
This looks good to me! I think all of the layout issues I saw are fixed. I'm pretty sure all of the polish was transferred over. @NevilleS might catch something I missed though
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## aking/2977/dezone-and-bring-nav-back #2992 +/- ##
=======================================================================
Coverage ? 86.86%
=======================================================================
Files ? 303
Lines ? 17177
Branches ? 2195
=======================================================================
Hits ? 14921
Misses ? 1844
Partials ? 412 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| // Ideally we could have one common layout used by *all* pages, but we couldn't | ||
| // come up with a common method here without introducing other gotchas, so having | ||
| // a slightly different layout was decided as the most maintainable option | ||
| // (see https://github.com/ethyca/fidesplus/pull/709) |
There was a problem hiding this comment.
You can probably remove this link now, it'll be confusing in this repo
| @@ -79,7 +79,7 @@ const TextInput = ({ | |||
| setType(type === "password" ? "text" : "password"); | |||
|
|
|||
| return ( | |||
| <InputGroup size="sm" mr="2"> | |||
| <InputGroup size="sm"> | |||
There was a problem hiding this comment.
Awesome, thanks for porting this. There might be a wider impact on other forms than when I first did this work but I'm pretty confident it'll be an improvement...
Progress on #2976
Code Changes
FixedLayout. It seemed like the conclusion was the only way to get the fixed/inside scrolling that the datamap UI has was to use a different layout componentSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
This branch should now have everything needed to run the datamap UI from admin UI. if anything looks different from the original datamap UI, do flag it!