Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hamburger menu with delete icon in user management table #2958

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

eastandwestwind
Copy link
Contributor

Closes #2860

Code Changes

  • Replace hamburger menu with delete icon in user management table

Steps to Confirm

  • Nav to user management table
  • Instead of seeing menu with edit and delete options:

Screenshot 2023-03-31 at 11 43 14 AM

you should instead see the delete trash icon:
Screenshot 2023-03-31 at 11 43 20 AM

when it's clicked, you should be prompted to confirm username to delete user:

Screenshot 2023-03-31 at 11 43 26 AM

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented Mar 31, 2023

Passing run #1182 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge a3e7b4f into 78865fb...
Project: fides Commit: 2153726824 ℹ️
Status: Passed Duration: 00:42 💡
Started: Apr 5, 2023 7:44 PM Ended: Apr 5, 2023 7:45 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@eastandwestwind eastandwestwind force-pushed the 2860-delete-icon-user-management-table branch from fbd952c to a3e7b4f Compare April 5, 2023 19:29
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great! 👏

@eastandwestwind eastandwestwind merged commit 43ae8eb into main Apr 6, 2023
@eastandwestwind eastandwestwind deleted the 2860-delete-icon-user-management-table branch April 6, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace hamburger menu on user management table with delete trash icon
2 participants