Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hamburger menu on user management table with delete trash icon #2860

Closed
eastandwestwind opened this issue Mar 17, 2023 · 11 comments · Fixed by #2958
Closed

Replace hamburger menu on user management table with delete trash icon #2860

eastandwestwind opened this issue Mar 17, 2023 · 11 comments · Fixed by #2958
Assignees

Comments

@eastandwestwind
Copy link
Contributor

Is your feature request related to a specific problem?

Replace this:
Screenshot 2023-03-17 at 3 37 54 PM

Describe the solution you'd like

A description of what you want to happen.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@eastandwestwind
Copy link
Contributor Author

This is blocked because we're waiting for @rsilvery to touch base with @renderbits on best approach. We may need to add ability to change password on the user management table, which would mean possibly keeping the hamburger menu around.

@rsilvery
Copy link
Contributor

@rsilvery
Copy link
Contributor

@eastandwestwind updated ticket for #700 to unblock you here.

@rsilvery
Copy link
Contributor

@eastandwestwind they can click into their profile and update it. Make sense?

@eastandwestwind
Copy link
Contributor Author

@rsilvery I'm unsure how #700 is related to this UX work- is that the right ticket you were mentioning?

UX fixes for Access Controls

I've requested access to the above ^

@rsilvery
Copy link
Contributor

No - sorry. I meant this ticket: https://github.com/ethyca/fidesplus/issues/700

@eastandwestwind
Copy link
Contributor Author

@rsilvery do we want a confirmation modal upon trash icon click, just like we do within the user profile:

Image

@rsilvery
Copy link
Contributor

Yes, I think so. But we don't need to have them enter any info - just confirm

@rsilvery
Copy link
Contributor

@eastandwestwind are we still blocked here?

@eastandwestwind
Copy link
Contributor Author

Nope I'm picking this up now

@Roger-Ethyca
Copy link
Contributor

verified all three on test env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants