Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authenticated privacy request route #1819

Merged
merged 8 commits into from
Nov 21, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Nov 18, 2022

Closes #1748

Code Changes

  • Created a function to facilitate both authenticated an unauthenticated privacy requests
  • Created a route for authenticated privacy requests
  • Added a config option to specify the parent server user name and password

Steps to Confirm

  • Add parent_server_username and parent_server_password to the fides.toml file.
  • login with provided credentials to get the authorization token.
  • use curl to verify an authenticated request can be sent.
curl --location --request POST 'http://0.0.0.0:8080/api/v1/privacy-request/authenticated' -H 'Content-Type: application/json' --data-raw '[{"identity": {"phone_number": "+19198675309"}, "policy_key": "default_access_policy"}]' -H "Authorization: Bearer {token}"

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

Paul Sanders added 3 commits November 17, 2022 23:39
Also only updates the user if the password has changed now.
@sanders41 sanders41 marked this pull request as ready for review November 18, 2022 20:03
src/fides/api/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, this all looks really good!

just one minor comment on a merge discrepancy that we should fix up. since you're on PTO and would like to get unblocked, i'm gonna make that change myself and hopefully then can just get this merged.

src/fides/api/ctl/database/seed.py Show resolved Hide resolved
src/fides/api/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me now!

@adamsachs adamsachs merged commit 0d36ef7 into main Nov 21, 2022
@adamsachs adamsachs deleted the ps-authenticated-privacy-request branch November 21, 2022 14:43
sadaqatullah pushed a commit that referenced this pull request Nov 22, 2022
Co-authored-by: Paul Sanders <pau@ethyca.com>
Co-authored-by: Adam Sachs <adam@Adams-MBP.hsd1.ma.comcast.net>
@adamsachs adamsachs mentioned this pull request Nov 29, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to Fides Connector to create a new privacy request without identity verification
2 participants