You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just approved and merged #1819, but then soon after merging and doing some more development based on the feature, i realized there's bug :(
On startup, if the parent user already exists and its password has not been updated in fides.toml, we try to create the user again, which leads to a duplicate key DB error. Since the exception goes uncaught, we actually end up totally erroring out on startup. The error isn't even logged or reported anywhere (an issue in its own right, likely due to #1228?) and the application just hangs with this as the last message in the logs:
fides-fides-1 | 2022-11-21 16:25:33.213 [INFO] (seed:create_or_update_parent_user:83): Creating parent user
Steps to Reproduce
Add a parent_server_username and parent_server_password to the fides.toml file.
Start fides once
Shut it down, start it again
Watch it hang
Expected behavior
This is the base case for parent user creation, there shouldn't be any error or problem starting up in this case
We should also take the opportunity to make sure we are catching any exceptions that are raised from the parent user creation, and at a minimum providing some information to the user about an issue that's encountered
I think we should also cleanly exit startup, because if a parent user is specified but there's an error in creation, then the app should not continue to boot up; it should call attention to the error so that it can be resolved
The text was updated successfully, but these errors were encountered:
Bug Description
I just approved and merged #1819, but then soon after merging and doing some more development based on the feature, i realized there's bug :(
On startup, if the parent user already exists and its password has not been updated in
fides.toml
, we try to create the user again, which leads to a duplicate key DB error. Since the exception goes uncaught, we actually end up totally erroring out on startup. The error isn't even logged or reported anywhere (an issue in its own right, likely due to #1228?) and the application just hangs with this as the last message in the logs:Steps to Reproduce
parent_server_username
andparent_server_password
to the fides.toml file.fides
onceExpected behavior
The text was updated successfully, but these errors were encountered: