Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught error on parent user creation #1832

Closed
adamsachs opened this issue Nov 21, 2022 · 0 comments · Fixed by #1834
Closed

Uncaught error on parent user creation #1832

adamsachs opened this issue Nov 21, 2022 · 0 comments · Fixed by #1834
Assignees
Labels
bug Something isn't working

Comments

@adamsachs
Copy link
Contributor

adamsachs commented Nov 21, 2022

Bug Description

I just approved and merged #1819, but then soon after merging and doing some more development based on the feature, i realized there's bug :(

On startup, if the parent user already exists and its password has not been updated in fides.toml, we try to create the user again, which leads to a duplicate key DB error. Since the exception goes uncaught, we actually end up totally erroring out on startup. The error isn't even logged or reported anywhere (an issue in its own right, likely due to #1228?) and the application just hangs with this as the last message in the logs:

fides-fides-1  | 2022-11-21 16:25:33.213 [INFO] (seed:create_or_update_parent_user:83): Creating parent user

Steps to Reproduce

  1. Add a parent_server_username and parent_server_password to the fides.toml file.
  2. Start fides once
  3. Shut it down, start it again
  4. Watch it hang

Expected behavior

  • This is the base case for parent user creation, there shouldn't be any error or problem starting up in this case
  • We should also take the opportunity to make sure we are catching any exceptions that are raised from the parent user creation, and at a minimum providing some information to the user about an issue that's encountered
    • I think we should also cleanly exit startup, because if a parent user is specified but there's an error in creation, then the app should not continue to boot up; it should call attention to the error so that it can be resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant