Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEP-911: Changing the shell variable to default display shell #724

Merged
merged 2 commits into from
Mar 23, 2023
Merged

IEP-911: Changing the shell variable to default display shell #724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
773e8d3
IEP-911: Changing the shell variable to default display shell as the …
alirana01 Mar 23, 2023
b2a224f
IEP-911: Changes for python buttons
alirana01 Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/update/DirectorySelectionDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.DirectoryDialog;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.FileDialog;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Shell;
Expand Down Expand Up @@ -105,7 +106,7 @@ public void modifyText(ModifyEvent e)
@Override
public void widgetSelected(SelectionEvent event)
{
DirectoryDialog dlg = new DirectoryDialog(shell);
DirectoryDialog dlg = new DirectoryDialog(Display.getDefault().getActiveShell());
dlg.setFilterPath(text.getText());
dlg.setText(Messages.DirectorySelectionDialog_IDFDirLabel);
dlg.setMessage(Messages.DirectorySelectionDialog_SelectIDFDirMessage);
Expand Down Expand Up @@ -141,7 +142,7 @@ public void modifyText(ModifyEvent e)
@Override
public void widgetSelected(SelectionEvent event)
{
FileDialog dlg = new FileDialog(shell);
FileDialog dlg = new FileDialog(Display.getDefault().getActiveShell());
dlg.setText(Messages.DirectorySelectionDialog_GitExecutableLocation);

String dir = dlg.open();
Expand Down Expand Up @@ -192,7 +193,7 @@ public void modifyText(ModifyEvent e)
@Override
public void widgetSelected(SelectionEvent event)
{
FileDialog dlg = new FileDialog(shell);
FileDialog dlg = new FileDialog(Display.getDefault().getActiveShell());
dlg.setText(Messages.DirectorySelectionDialog_PyExecutableLocation);

String dir = dlg.open();
Expand Down