Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEP-911: Changing the shell variable to default display shell #724

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

alirana01
Copy link
Collaborator

@alirana01 alirana01 commented Mar 23, 2023

Description

Changing the shell variable to default display shell as the active display and window can be different

Fixes # (IEP-911)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Use jira reference ticket to reproduce and test

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Verified on all platforms - Windows,Linux and macOS

@alirana01 alirana01 self-assigned this Mar 23, 2023
Copy link
Collaborator Author

@alirana01 alirana01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting to display default's shell as the active window switching on Linux caused this to be passed as null

@alirana01 alirana01 changed the title [WIP] IEP-911: Changing the shell variable to default display shell IEP-911: Changing the shell variable to default display shell Mar 23, 2023
@AndriiFilippov
Copy link
Collaborator

@alirana01 hi !

Git and Python "Browse" buttons still inactive.
ESP-IDF "Browse" button works fine 👍

@kolipakakondal kolipakakondal added this to the v2.9.1 milestone Mar 23, 2023
@kolipakakondal kolipakakondal added the bug Something isn't working label Mar 23, 2023
@alirana01
Copy link
Collaborator Author

@alirana01 hi !

Git and Python "Browse" buttons still inactive. ESP-IDF "Browse" button works fine 👍

Hi @AndriiFilippov please try after the latest push. I forgot to push the changes for those

@AndriiFilippov
Copy link
Collaborator

@alirana01

LGTM 👍

@alirana01 alirana01 merged commit f55f1bf into master Mar 23, 2023
@alirana01 alirana01 deleted the IEP-911 branch March 23, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants