Feature/radio singletons #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just out of curiosity: does changing the opt-level change anything regarding those issues? I know it shouldn't for RV but who knows? |
|
I looked into this a bit more and I was running into the issue fixed in esp-rs/esp-hal@c01317e 😆. Everything was fine after that. Sadly we need a new esp-hal release before we can merge this, so I'll keep it as draft for now. |
- Uses the RADIO singletons when creating wifi/ble/esp_now - Updates all examples to use the singletons - Simplfy esp_now::ReceiveFuture
MabezDev
force-pushed
the
feature/radio-singletons
branch
from
dc20877
to
99662ed
Compare
MabezDev
force-pushed
the
feature/radio-singletons
branch
3 times, most recently
from
2a43025
to
4f15b0a
Compare
bjoernQ
reviewed
Mar 28, 2023
bjoernQ
approved these changes
Mar 28, 2023
MabezDev
force-pushed
the
feature/radio-singletons
branch
from
4f15b0a
to
2611ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the BLE example stopped working for me (at least on esp32c3), but the coex one does? I don't know why but coex will also fail if the
radio::Bluetoothstruct is passed via&mut, even though it shouldn't make a difference...