Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import-target): Add resolution error reason #264

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented May 6, 2024

Fixed test cases (based on #231).

fixes #182

@aladdin-add aladdin-add force-pushed the pr231 branch 4 times, most recently from 86b6cd7 to 4fd0965 Compare May 6, 2024 08:30
@aladdin-add aladdin-add requested a review from scagood May 6, 2024 08:34
@aladdin-add aladdin-add marked this pull request as ready for review May 6, 2024 09:31
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small non blocking comments, but in general I like it! Thank you

Comment on lines +18 to +21
const platform = os.platform()
exports.isCaseSensitiveFileSystem =
platform === "linux" || platform === "freebsd" || platform === "openbsd"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this in a different file? I don't think it belongs with the rule tester

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, renamed to test-helpers. :)

@@ -8,12 +8,17 @@ const { RuleTester } = require("eslint")
const { FlatRuleTester } = require("eslint/use-at-your-own-risk")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am starting to think we should make these patches for different eslint versions into a package

@aladdin-add aladdin-add merged commit 982a723 into master May 7, 2024
25 checks passed
@aladdin-add aladdin-add deleted the pr231 branch May 7, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: import-target mutes resolution errors
2 participants