Skip to content

Commit

Permalink
chore: rename eslint-rule-tester to test-helpers
Browse files Browse the repository at this point in the history
  • Loading branch information
aladdin-add committed May 7, 2024
1 parent a1c3a65 commit 39ad49f
Show file tree
Hide file tree
Showing 42 changed files with 58 additions and 73 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,6 @@
"*.md": "markdownlint --fix"
},
"imports": {
"#eslint-rule-tester": "./tests/eslint-rule-tester.js"
"#test-helpers": "./tests/test-helpers.js"
}
}
10 changes: 0 additions & 10 deletions tests/helpers.js

This file was deleted.

43 changes: 19 additions & 24 deletions tests/lib/configs/eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
const assert = require("assert")
const path = require("path")
const { LegacyESLint } = require("eslint/use-at-your-own-risk")
// const {ESLint} = require("eslint")
const { gtEslintV8 } = require("../../helpers")
const originalCwd = process.cwd()

// this is needed as `recommended` config was cached
Expand All @@ -15,7 +13,7 @@ function clearRequireCache() {
}

describe("node/recommended config", () => {
;(gtEslintV8 ? describe : describe.skip)("in CJS directory", () => {
describe("in CJS directory", () => {
const root = path.resolve(__dirname, "../../fixtures/configs/cjs/")

/** @type {Linter} */
Expand Down Expand Up @@ -131,27 +129,24 @@ describe("node/recommended config", () => {
},
])
})
;(gtEslintV8 ? it : it.skip)(
"*.cjs files should be a script.",
async () => {
const report = await linter.lintText("import 'foo'", {
filePath: path.join(root, "test.cjs"),
})

assert.deepStrictEqual(report[0].messages, [
{
column: 1,
fatal: true,
line: 1,
message:
"Parsing error: 'import' and 'export' may appear only with 'sourceType: module'",
ruleId: null,
nodeType: null,
severity: 2,
},
])
}
)
it("*.cjs files should be a script.", async () => {
const report = await linter.lintText("import 'foo'", {
filePath: path.join(root, "test.cjs"),
})

assert.deepStrictEqual(report[0].messages, [
{
column: 1,
fatal: true,
line: 1,
message:
"Parsing error: 'import' and 'export' may appear only with 'sourceType: module'",
ruleId: null,
nodeType: null,
severity: 2,
},
])
})

it("*.mjs files should be a module.", async () => {
const report = await linter.lintText("import 'foo'", {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/callback-return.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/callback-return")
const ruleTester = new RuleTester()

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/exports-style.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/exports-style")

new RuleTester({ languageOptions: { ecmaVersion: 11 } }).run(
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/file-extension-in-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

const path = require("path")
const { Linter } = require("eslint")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("../../test-helpers").RuleTester
const rule = require("../../../lib/rules/file-extension-in-import")

const DynamicImportSupported = (() => {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/global-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/global-require")

const ERROR = { messageId: "unexpected", type: "CallExpression" }
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/handle-callback-err.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/handle-callback-err")
const ruleTester = new RuleTester()

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/hashbang.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/shebang")

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-callback-literal.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-callback-literal")
const tsParser = require("@typescript-eslint/parser")

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-deprecated-api.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const { RuleTester } = require("#eslint-rule-tester")
const { RuleTester } = require("#test-helpers")
const rule = require("../../../lib/rules/no-deprecated-api")

const ruleTester = new RuleTester()
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-exports-assign.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const { RuleTester } = require("#eslint-rule-tester")
const { RuleTester } = require("#test-helpers")
const rule = require("../../../lib/rules/no-exports-assign.js")

new RuleTester({
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-extraneous-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

const path = require("path")
const { Linter } = require("eslint")
const { RuleTester } = require("#eslint-rule-tester")
const { RuleTester } = require("#test-helpers")
const rule = require("../../../lib/rules/no-extraneous-import")

const DynamicImportSupported = (() => {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-extraneous-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-extraneous-require")

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-hide-core-modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
//------------------------------------------------------------------------------

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-hide-core-modules")

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-missing-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

const path = require("path")
const { Linter } = require("eslint")
const { RuleTester, isCaseSensitiveFileSystem } = require("#eslint-rule-tester")
const { RuleTester, isCaseSensitiveFileSystem } = require("../../test-helpers")
const rule = require("../../../lib/rules/no-missing-import")

const DynamicImportSupported = (() => {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-missing-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const { RuleTester, isCaseSensitiveFileSystem } = require("#eslint-rule-tester")
const { RuleTester, isCaseSensitiveFileSystem } = require("../../test-helpers")
const rule = require("../../../lib/rules/no-missing-require")

const tsReactExtensionMap = [
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-mixed-requires.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-mixed-requires")
const ruleTester = new RuleTester()

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-new-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-new-require")

new RuleTester().run("no-new-require", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-path-concat.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-path-concat")

new RuleTester().run("no-path-concat", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-process-env.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-process-env")

new RuleTester().run("no-process-env", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-process-exit.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-process-exit")
const ruleTester = new RuleTester()

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-restricted-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

const path = require("path")
const { Linter } = require("eslint")
const { RuleTester } = require("#eslint-rule-tester")
const { RuleTester } = require("#test-helpers")
const rule = require("../../../lib/rules/no-restricted-import")

const DynamicImportSupported = (() => {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-restricted-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-restricted-require")

new RuleTester().run("no-restricted-require", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-sync.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-sync")

new RuleTester().run("no-sync", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unpublished-bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-unpublished-bin")

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unpublished-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

const path = require("path")
const { Linter } = require("eslint")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-unpublished-import")
const globals = require("globals")

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unpublished-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../lib/rules/no-unpublished-require")

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unsupported-features/es-builtins.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* See LICENSE file in root directory for full license.
*/
"use strict"
const { RuleTester } = require("#eslint-rule-tester")
const { RuleTester } = require("#test-helpers")
const rule = require("../../../../lib/rules/no-unsupported-features/es-builtins")
const globals = require("globals")

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unsupported-features/es-syntax.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict"

const path = require("path")
const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/no-unsupported-features/es-syntax")

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unsupported-features/node-builtins.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("../../../test-helpers").RuleTester
const rule = require("../../../../lib/rules/no-unsupported-features/node-builtins")

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/buffer")

new RuleTester().run("prefer-global/buffer", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/console.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/console")

new RuleTester().run("prefer-global/console", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/process.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/process")

new RuleTester().run("prefer-global/process", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/text-decoder.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/text-decoder")

new RuleTester().run("prefer-global/text-decoder", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/text-encoder.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/text-encoder")

new RuleTester().run("prefer-global/text-encoder", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/url-search-params.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/url-search-params")

new RuleTester().run("prefer-global/url-search-params", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/prefer-global/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
"use strict"

const RuleTester = require("#eslint-rule-tester").RuleTester
const RuleTester = require("#test-helpers").RuleTester
const rule = require("../../../../lib/rules/prefer-global/url")

new RuleTester().run("prefer-global/url", rule, {
Expand Down
Loading

0 comments on commit 39ad49f

Please sign in to comment.