Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting variables prefix #154

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Add setting variables prefix #154

merged 2 commits into from
Apr 27, 2022

Conversation

anetteu
Copy link
Member

@anetteu anetteu commented Apr 25, 2022

Solves #150

@anetteu anetteu changed the title Env prefix Add setting variables prefix Apr 25, 2022
@anetteu anetteu self-assigned this Apr 25, 2022
@anetteu anetteu linked an issue Apr 25, 2022 that may be closed by this pull request
Remove env specifiers in settings #150
Closed
GodVenn
GodVenn approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anetteu
Add FLOTILLA_ prefix to settings variables
d9e0cd1
@anetteu
Remove env specifiers in setting
4dd12cd 
There is no need to specify the env variable as long as it is the same
as settings variable.
@anetteu anetteu merged commit 627b1c3 into equinor:main Apr 27, 2022
@anetteu anetteu deleted the env-prefix branch April 27, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodVenn GodVenn GodVenn approved these changes

Assignees

@anetteu anetteu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove env specifiers in settings
2 participants
@anetteu @GodVenn