Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env specifiers in settings #150

Closed
aeshub opened this issue Apr 22, 2022 · 0 comments · Fixed by #154
Closed

Remove env specifiers in settings #150

aeshub opened this issue Apr 22, 2022 · 0 comments · Fixed by #154
Assignees
Labels
good first issue Good for newcomers improvement Improvement to existing functionality

Comments

@aeshub
Copy link
Contributor

aeshub commented Apr 22, 2022

Describe the improvement you would like to see
Remove the specification of env for every setting as these are redundant, it will default to the same name as the setting.

In addition, add a prefix FLOTILLA_ the same way as has been done in ISAR.

How will this change existing functionality?
Check that environment variable that may be passed in through docker-compose will still adhere to the correct prefix.

How will this improvement affect the current Threat Model?
Not affected.

@aeshub aeshub added improvement Improvement to existing functionality good first issue Good for newcomers labels Apr 22, 2022
@anetteu anetteu self-assigned this Apr 25, 2022
@anetteu anetteu linked a pull request Apr 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants