feat: Enabled VRF routes in metal-cli #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codinja1188
force-pushed
the
vrf-routes
branch
from
822e510
to
13cade1
Compare
codinja1188
force-pushed
the
vrf-routes
branch
from
13cade1
to
81c3e44
Compare
codinja1188
force-pushed
the
vrf-routes
branch
from
81c3e44
to
1febd5e
Compare
codinja1188
force-pushed
the
vrf-routes
branch
from
1febd5e
to
e7ad994
Compare
ctreatma
reviewed
Jan 3, 2024
codinja1188
force-pushed
the
vrf-routes
branch
from
e7ad994
to
a117918
Compare
ctreatma
requested changes
Jan 25, 2024
codinja1188
force-pushed
the
vrf-routes
branch
from
a117918
to
6329fc8
Compare
codinja1188
force-pushed
the
vrf-routes
branch
from
6329fc8
to
b2d1a6e
Compare
ctreatma
reviewed
Jan 26, 2024
codinja1188
requested a deployment
to
external
GitHub Actions
Abandoned
codinja1188
force-pushed
the
vrf-routes
branch
from
b2d1a6e
to
c763e7a
Compare
ctreatma
reviewed
Jan 30, 2024
test/helper/helper.go
Outdated
| @@ -28,7 +28,7 @@ func TestClient() *metalv1.APIClient { | |||
| configuration.AddDefaultHeader("X-Auth-Token", os.Getenv("METAL_AUTH_TOKEN")) | |||
| configuration.UserAgent = fmt.Sprintf("metal-cli/test-helper %s", configuration.UserAgent) | |||
| // For debug purpose | |||
| // configuration.Debug = true | |||
| configuration.Debug = true | |||
There was a problem hiding this comment.
I know you're in the process of updating the tests; just remember to turn Debug off before this gets merged.
codinja1188
force-pushed
the
vrf-routes
branch
from
c763e7a
to
e641d33
Compare
ctreatma
approved these changes
Jan 30, 2024
ctreatma
reviewed
Jan 30, 2024
Comment on lines
+116
to
+119
| // Actually user have to wait for 5 min to updae the VRF-routes. This test case is skipped intentionally | ||
| if true { | ||
| t.Skip("Skipping this test because someCondition is true") | ||
| } |
There was a problem hiding this comment.
In cases like this it is much better to implement a wait function so that the test can be executed than it is to skip the test. #441 enables this test and fixes a bug that was uncovered by running the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues it address?
#414