Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Metal VRF Routes #414

Closed
displague opened this issue Dec 15, 2023 · 1 comment
Closed

Add support for Metal VRF Routes #414

displague opened this issue Dec 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@displague
Copy link
Member

displague commented Dec 15, 2023

What problem are you facing?

With #268 there are a few features of VRF yet to be implemented. Among them is VRF Routes configuration.

https://github.com/equinix-labs/metal-go/blob/main/docs/VRFsApi.md

Method HTTP request Description
CreateVrfRoute Post /vrfs/{id}/routes Create a VRF route
DeleteVrfRouteById Delete /routes/{id} Delete a VRF Route
FindVrfRouteById Get /routes/{id} Retrieve a VRF Route
GetVrfRoutes Get /vrfs/{id}/routes Retrieve all routes in the VRF
UpdateVrfRouteById Put /routes/{id} Update a VRF Route

How could the Equinix Metal CLI help solve this problem?

metal vrf routes-create --vrf-id {vrf_id}
metal vrf routes-update --route-id {route_id}
metal vrf routes-get --route-id {route_id}
metal vrf routes-delete --route-id {route_id}

One of these two ids should probably be "id" as an argument. Use whatever the current convention is for subcommands with IDs and when we use the short "id" vs the subcommand prefix.

@displague displague added the enhancement New feature or request label Dec 15, 2023
@codinja1188
Copy link
Contributor

/assign @codinja1188

ctreatma pushed a commit that referenced this issue Jan 30, 2024
## What issues it address?

#414

- Enabled VRF routes in Metal-cli.
- Improved metal gateways to support Vrf gateway inputs.

Co-authored-by: codinja1188 <3358152+vasubabu@users.noreply.github.com>
cprivitere added a commit that referenced this issue Jan 31, 2024
The test for the VRF route update subcommand was explicitly skipped. I
added a helper function to wait for the VRF route to be ready before
testing the update subcommand, but when the test was enabled it failed
because the subcommand was not capable of updating tags without updating
all other VRF route properties.

In addition to enabling the test for the VRF route update subcommand,
this updates the subcommand itself so that it only updates a VRF route
property if the user set the corresponding CLI flag.

Part of #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants