Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4888 - Enable editing sequences by click between symbols #5093

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jul 12, 2024

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

);
)
.attr('style', 'user-select: none;')
.attr('cursor', this.isSequenceEditModeTurnedOn ? 'text' : 'default');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's duplicated a few times, possibly could be refactored

@rrodionov91 rrodionov91 merged commit f83862e into master Jul 25, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4888-edit-sequence-simplify branch July 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable editing sequences by click between symbols or double click on symbol
2 participants