Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable editing sequences by click between symbols or double click on symbol #4888

Closed
olganaz opened this issue Jun 26, 2024 · 2 comments · Fixed by #5093
Closed

Enable editing sequences by click between symbols or double click on symbol #4888

olganaz opened this issue Jun 26, 2024 · 2 comments · Fixed by #5093
Assignees
@rrodionov91
Labels
feature request Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.24.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Jun 26, 2024 •
edited by ljubica-milovic
Loading

Background
The current approach of editing existed sequence with a right-click is not intuitive for users. Additionally to rClick option an approach to edit sequence by clicking between symbols and double-clicking a symbol should be implemented.

Requirements

View mode:

  1. While user hovers along the sequence, the cursor should be displayed as a arrow.
  2. If user hovers between the symbols (4 pixel space), the cursor should become a caret.
  3. If user clicks between two symbols (when cursor becomes a caret) the edit mode should be turned on and the cursor should be placed between those two symbols.
  4. Double-click on the symbol should turn on the edit mode AND cursor (blinking line) should be placed in corresponding cell of the grid before the symbol AND that symbol should be highlighted.
    image
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Jul 9, 2024
@rrodionov91 rrodionov91 self-assigned this Jul 11, 2024
rrodionov91 added a commit that referenced this issue Jul 12, 2024
@rrodionov91
#4888 - Enable editing sequences by click between symbols
95eea89
@rrodionov91 rrodionov91 linked a pull request Jul 12, 2024 that will close this issue
#4888 - Enable editing sequences by click between symbols #5093
Merged
9 tasks
@ljubica-milovic ljubica-milovic changed the title Enable editing sequences by click between symbols Enable editing sequences by click between symbols or double click on symbol Jul 19, 2024
rrodionov91 added a commit that referenced this issue Jul 23, 2024
@rrodionov91
#4888 - Enable editing sequences by click between symbols
0674d32
rrodionov91 added a commit that referenced this issue Jul 25, 2024
@rrodionov91
#4888 - Enable editing sequences by click between symbols (#5093)
f83862e 
- added enabling sequence edit mode by clicking between symbols or double click on symbol
- fixed bug with order of sequence items
- fixed tests
- updated screenshots
This was referenced Jul 31, 2024
Closed
Open
Open
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin mentioned this issue Aug 1, 2024
Open
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

@Zhirnoff Zhirnoff mentioned this issue Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
feature request Test Cases Written Test cases has been written for that issue
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4888 - Enable editing sequences by click between symbols epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @olganaz @ljubica-milovic