Add support for lifespan in ASGIDispatch #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
florimondmanca
force-pushed
the
feat/asgi-lifespan
branch
from
9a263d2
to
6f0a47a
Compare
sethmlarson
approved these changes
Sep 22, 2019
florimondmanca
force-pushed
the
feat/asgi-lifespan
branch
from
fcd6855
to
87397a7
Compare
|
As per #350 I'm kinda keen to punt on this. Whaddya reckon? |
Yep, sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #350
Don't know yet whether this should be considered or not, but I thought I'd give it a shot. :)
Random thoughts: handling errors correctly for this turned out to be way more complicated than I initially expected. The
background_managerinterface hasn't helped, but I think it can't easily be improved because we use class-based async context managers a lot, instead of e.g. using@asynccontextmanager, which would have the benefit of handling exceptions the right way all the time.