Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Configurations #353

Merged
merged 7 commits into from
Sep 20, 2019
Merged

Proxy Configurations #353

merged 7 commits into from
Sep 20, 2019

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Sep 18, 2019

Here's part 2 of the HTTP proxy PRs, configuring on the client. I also worked out some issues with re-using the TCP tunnel connection.

Closes #33

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Really enjoy having the documentation alongside the code here. :)

I've left a couple of comments. I also think we should update the Developer Interface docs with the proxies parameter where relevant.

docs/advanced.md Show resolved Hide resolved
docs/advanced.md Show resolved Hide resolved
docs/advanced.md Outdated Show resolved Hide resolved
docs/environment_variables.md Outdated Show resolved Hide resolved
tests/dispatch/test_proxy_http.py Outdated Show resolved Hide resolved
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Well done. 🎉

@florimondmanca
Copy link
Member

I also think we should update the Developer Interface docs with the proxies parameter where relevant.

I've just looked at that part of the docs and honestly it's a bit of a mess unfortunately — there are already multiple parameters missing, and I think the overall presentation could be improved. We can add the proxies parameter there, but we could also include that in a PR that cleans up this section of the docs. What do you prefer?

Besides, I think we forgot to add the proxies parameter to the high-level httpx API as well.

(On this note, I know we don't just use **kwargs on the various requesting methods because of the khwarg problem, but I have the feeling we could write some tests to make sure all those entrypoints are consistent in terms of exposed parameters. I may look into this. :))

@sethmlarson
Copy link
Contributor Author

I agree that part of the docs needs a revamp, all that spam about parameters in get, post, options, etc isn't helping anyone. :)

I'm going to add the parameter in this PR then we can cleanup separately.

@sethmlarson
Copy link
Contributor Author

@florimondmanca How do these latest changes look?

Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🌟

Just a minor comment and a nitpick, otherwise 👍

httpx/client.py Outdated Show resolved Hide resolved
httpx/client.py Show resolved Hide resolved
@sethmlarson
Copy link
Contributor Author

@florimondmanca @yeraydiazdiaz Am I good to merge this?

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit b0fa085 into master Sep 20, 2019
@sethmlarson sethmlarson deleted the proxy-config branch September 20, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment support
3 participants