Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async recommendations #2727

Merged
merged 6 commits into from
Jun 15, 2023
Merged

async recommendations #2727

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d276fec
async recommendations
trondhindenes May 31, 2023
4578635
better
trondhindenes Jun 7, 2023
4c0dfdd
Merge branch 'master' into async-doc-recommendation
tomchristie Jun 7, 2023
972e09d
Update docs/async.md
trondhindenes Jun 12, 2023
bbbf09f
added async recommendation tweak
trondhindenes Jun 12, 2023
30704ae
Merge branch 'master' into async-doc-recommendation
tomchristie Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/async.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ async with httpx.AsyncClient() as client:
...
```

!!! warning
In order to get the most benefit from connection pooling, make sure you're not instantiating multiple client instances - for example by using `async with` inside a "hot loop". This can be achieved either by having a single scoped client that's passed throughout wherever it's needed, or by having a single global client instance.

Alternatively, use `await client.aclose()` if you want to close a client explicitly:

```python
Expand Down