async recommendations #2727
Merged
async recommendations #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
reviewed
Jun 6, 2023
tomchristie
reviewed
Jun 12, 2023
Co-authored-by: Tom Christie <tom@tomchristie.com>
|
sorry to be pedantic, I just really want to get the wording right. I merged your suggestion and added a bit more onto it. Does that work you think? |
tomchristie
approved these changes
Jun 13, 2023
|
@tomchristie nice thanks! I don't have merge access, so hopefully a maintainer will merge this in at some point. Thanks for helping out with this PR! |
karpetrosyan
approved these changes
Jun 15, 2023
|
@trondhindenes - Ah gotcha, I've sent you a team invite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update docs regarding usage of client context manager inside hot loops, since we know that it negatively affects performance
Checklist