Add logger trace #79
Merged
Add logger trace #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeraydiazdiaz
force-pushed
the
logger-trace
branch
2 times, most recently
from
0f95cf0
to
71ff944
Compare
yeraydiazdiaz
force-pushed
the
logger-trace
branch
from
71ff944
to
d237cfb
Compare
|
Just thought we may want to consider matching |
|
Yeah either that or support both? |
|
I guess we could have httpx set HTTPCORE_LOG_LEVEL if needed, but maybe that’s overdoing it a bit. |
|
I'd say support both makes more sense, I'll add that. |
tomchristie
approved these changes
May 11, 2020
|
Thanks! 🚀 |
|
👍- 0.8.4 Release PR welcome at this point then, I guess? |
|
Yup, I can put that together 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
I tried to replicate the calls we used to have in httpx, may have missed some but we can just add them as needed moving forward.