Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back TRACE logs #58

Closed
florimondmanca opened this issue Apr 12, 2020 · 3 comments · Fixed by #79
Closed

Bring back TRACE logs #58

florimondmanca opened this issue Apr 12, 2020 · 3 comments · Fixed by #79

Comments

@florimondmanca
Copy link
Member

florimondmanca commented Apr 12, 2020

I notice the logger.trace() calls we had previously in HTTPX are not present in this package anymore.

I suppose this was done out of simplicity, but I think we should bring them back. They were super useful to debug networking issues, connection management issues, etc.

So here's an issue for trackig purposes. :-)

@tomchristie
Copy link
Member

Yeah that's my fault,

I think it was while I was trying to do a bit of refactoring of the HTTP/2 and pulling everything across to httpcore. Is it clear what environment variable naming we ought to be using given that we've got a proper httpx/httpcore split now?

@florimondmanca
Copy link
Member Author

For env vars we could have an HTTPCORE_LOG_LEVEL, and make HTTPX set that when HTTPX_LOG_LEVEL is set too.

@tomchristie
Copy link
Member

Sounds reasonable yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants