Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance RFC #0776 "Author Built-In Blueprints in TypeScript" to Stage Recommended #912

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Mar 13, 2023

Advance #776 to the Recommended Stage

Summary

This pull request is advancing the RFC to the Recommended Stage.

An FCP is required before merging this PR to advance.

Recommended Stage Summary

The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.

To reach the "Recommended" stage, the following should be true:

If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.

If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.

If the proposal updates or replaces an existing feature, high-quality codemods are available.

If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.

If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".

Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.

An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.

Checklist to move to Recommended

  • Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met
  • If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
  • If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
  • If the proposal updates or replaces an existing feature, high-quality codemods are available
  • If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
  • If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
  • This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Recommended PR to move to the Recommended Stage labels Mar 13, 2023
@wagenet wagenet added the E-Polaris Work for the Polaris Edition label Mar 23, 2023
@ef4
Copy link
Contributor

ef4 commented Jul 28, 2023

@gitKrystan has volunteered to champion this going forward to make sure it moves.

@gitKrystan
Copy link
Contributor

Per TS core meeting:

Re updating guides, minimally we should add a TS page to the existing guides to cover this and other TS documentation that currently exists in multiple places. This will give people something to react to while we work on a more integrated TS/JS interactive guide.

@gitKrystan
Copy link
Contributor

I've started a PR to the Guides for basic TS documentation. WIP PR here: ember-learn/guides-source#1960

@ef4
Copy link
Contributor

ef4 commented Sep 29, 2023

For this particular RFC (which is about blueprint authoring), the remaining piece of docs needed is an update to https://cli.emberjs.com/release/advanced-use/blueprints/

The other TS guides content linked above is great and important for some of the other related TS RFCs, but not a blocker for this one.

@achambers
Copy link
Contributor

PR to add shouldTransformTypescript property to cli.emberjs.com/release/advanced-use/blueprints

ember-learn/cli-guides#311

@achambers
Copy link
Contributor

PR to add --typescript option to https://cli.emberjs.com/release/advanced-use/cli-commands-reference/

ember-learn/cli-guides#312

@achambers achambers marked this pull request as ready for review December 8, 2023 15:53
@ef4 ef4 merged commit bc0b57c into master Dec 15, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the advance-rfc-0776 branch December 15, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Polaris Work for the Polaris Edition Final Comment Period RFC Advancement S-Recommended PR to move to the Recommended Stage T-TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants