Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript guides #1960

Merged
merged 63 commits into from
Oct 23, 2023
Merged

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented Aug 27, 2023

image

While we have grand plans to eventually have a js/ts toggle for all of the guides, we need something to point to in the meantime. In this PR, I am adding initial TypeScript guides pulled from the various resources currently scattered across the interwebs to use as a starting point.

These pages currently will not show up in the table of contents. You'll have to visit the link directly. The purpose of this is to allow us to merge this mega-PR and continue to iterate without being fully released. In the meantime, we can link people directly to these pages with the caveat that the pages are still under construction.

Sources:

This will help us close out emberjs/rfcs#952

To review:

Visit deploy preview linked below and navigate to ./release/using-typescript/
(e.g. https://deploy-preview-1960--ember-guides.netlify.app/release/using-typescript/ for the deploy that was current at the time of this writing)

Review for:

  • Typos
  • Mistakes
  • Completeness

Please make liberal use of the GitHub suggestions feature because I am starting to get bleary-eyed looking at this for so long. 🙏

@netlify
Copy link

netlify bot commented Aug 27, 2023

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit 98880da
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/653696ab067e360007d925d0
😎 Deploy Preview https://deploy-preview-1960--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started! I left a bunch of suggestions, and I think we want to keep these out of the top-level outline for now, but getting it started this way is awesome, and now we can iterate!

@gitKrystan
Copy link
Contributor Author

gitKrystan commented Oct 22, 2023

Lint should be fixed now.

I played w/ moving the chapter up a level (per discussion on Discord) and it makes the initial TOC super long + pushes some of the TypeScript chapters to the same level as their top-level equivalent (e.g. "Getting Started" at the same level as "TypeScript: Getting Started") which I found a bit confusing.

I also played with splitting up the Invokables chapter and there wasn't a great place to split it (it's written as one narrative that references itself a lot), so I left it as is.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@mansona mansona disabled auto-merge October 23, 2023 16:01
@mansona mansona merged commit 60f2802 into ember-learn:master Oct 23, 2023
3 of 4 checks passed
@gitKrystan gitKrystan deleted the typescript-guides branch October 23, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants