Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HTTP Mock to addon #576

Closed
wants to merge 2 commits into from
Closed

Conversation

mehulkar
Copy link
Contributor

@wagenet
Copy link
Member

wagenet commented Jul 23, 2022

This seems reasonable to me. I'll see what I can do to get it moving.

@bertdeblock
Copy link
Member

I've added this RFC to next week's agenda.

@wagenet wagenet added the S-Proposed In the Proposed Stage label Dec 2, 2022
@kategengler kategengler added S-Exploring In the Exploring RFC Stage and removed S-Proposed In the Proposed Stage labels Dec 7, 2022
@kategengler
Copy link
Member

We discussed this at the CLI meeting today. We think is a good path forward and are open to accepting if there is someone volunteering to move it forward.

@runspired
Copy link
Contributor

Moving to an addon seems great if doable; however, it would be better if we exposed a serverMiddleware hook directly to ember apps for this purpose. The dance otherwise is very complicated and not forward-thinking as we move away from older addon patterns. I'd like to see http-mocks be the default story, mirage is .... not an ideal solution for anyone.

@wagenet
Copy link
Member

wagenet commented Jan 13, 2023

@runspired could you expand on this a bit. I'm guessing you'd suggest an ember-cli RFC for this change?

@runspired
Copy link
Contributor

@wagenet currently to implement anything as a server-middleware it must be created as an addon. EmberCLI has no ability currently for sever middleware to be added except that mechanism. This makes creating solutions for apps that hook into the serve process very complicated: which includes any proposed http-mock replacement. Instead of mocks in-app you end up with mocks in an addon in the app.

@runspired
Copy link
Contributor

Basically my suggestion is for embercli to add registerMiddleware to the EmberApp in ember-cli-build

@kategengler
Copy link
Member

We think the medium-term plan should be to deprecate HTTP mock, rather than extract it. To that end, we are putting this in FCP to close.

@kategengler kategengler added the FCP to close The core-team that owns this RFC has moved that this RFC be closed. label Oct 20, 2023
@mehulkar mehulkar closed this Oct 20, 2023
@mehulkar mehulkar deleted the http-mock branch October 20, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FCP to close The core-team that owns this RFC has moved that this RFC be closed. Needs Champion S-Exploring In the Exploring RFC Stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants