Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport ci fix #513

Merged
merged 3 commits into from Jan 29, 2020
Merged

backport ci fix #513

merged 3 commits into from Jan 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2020

Backporting my changes for #507, #510, #506.
Not sure if this is entirely necessary but it should ensure the CI checks pass.

Both scripts differed only by the binary name so it makes sense to
condense them into one. I also specified the interpreter using a shebang for
flexibility.
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @efx

@amyrlam amyrlam merged commit 39aacfb into ember-learn:issue/embertimes-133 Jan 29, 2020
@ghost ghost deleted the backport-ci-fix branch January 29, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants