Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condense markdown lint and alex validation behavior #506

Merged
merged 1 commit into from Jan 27, 2020
Merged

condense markdown lint and alex validation behavior #506

merged 1 commit into from Jan 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2020

Both scripts differed only by the binary name so it makes sense to
condense them into one. I also specified the interpreter using a shebang for
flexibility.

What it does

Makes the lint script runner more maintainable and portable.

Related Issue(s)

Sources

Both scripts differed only by the binary name so it makes sense to
condense them into one. I also specified the interpreter using a shebang for
flexibility.
@ghost
Copy link
Author

ghost commented Jan 27, 2020

Do close this if #7 is the future 😄

@ghost ghost mentioned this pull request Jan 27, 2020
@amyrlam amyrlam mentioned this pull request Jan 27, 2020
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's give this a try! cc @ember-learn/ember-times-editors

#7 is the future, but not sure of the timeline rn

@amyrlam
Copy link
Member

amyrlam commented Jan 27, 2020

thanks @efx!

@amyrlam amyrlam merged commit 26ed8e1 into ember-learn:master Jan 27, 2020
@ghost ghost deleted the condense-validation-scripts branch January 27, 2020 21:12
@ghost ghost mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants