validate

elys-network · Sep 18, 2024 · 6f08880 · 6f08880
1 parent 5a23a3a
commit 6f08880
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/x/tradeshield/types/message_update_params.go b/x/tradeshield/types/message_update_params.go
@@ -43,6 +43,19 @@ func (msg *MsgUpdateParams) ValidateBasic() error {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid creator address (%s)", err)
 	}
 
-	// TODO: Validate params
+	// Validate params
+	if msg.Params.LimitProcessOrder <= 0 {
+		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "LimitProcessOrder must be greater than 0")
+	}
+	if msg.Params.RewardPercentage.IsNegative() {
+		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "RewardPercentage must be non-negative")
+	}
+	if msg.Params.MarginError.IsNegative() {
+		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "MarginError must be non-negative")
+	}
+	if msg.Params.MinimumDeposit.IsNegative() {
+		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "MinimumDeposit must be non-negative")
+	}
+
 	return nil
 }