Skip to content

Commit

Permalink
update params
Browse files Browse the repository at this point in the history
  • Loading branch information
amityadav0 committed Sep 18, 2024
1 parent 1e84e22 commit 5a23a3a
Show file tree
Hide file tree
Showing 5 changed files with 74 additions and 8 deletions.
1 change: 1 addition & 0 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,7 @@ func NewElysApp(
appCodec,
keys[tradeshieldmoduletypes.StoreKey],
keys[tradeshieldmoduletypes.MemStoreKey],
authtypes.NewModuleAddress(govtypes.ModuleName).String(),
)
tradeshieldModule := tradeshieldmodule.NewAppModule(appCodec, app.TradeshieldKeeper, app.AccountKeeper, app.BankKeeper)

Expand Down
3 changes: 3 additions & 0 deletions testutil/keeper/tradeshield.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/cosmos/cosmos-sdk/store"
storetypes "github.com/cosmos/cosmos-sdk/store/types"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/address"
"github.com/elys-network/elys/x/tradeshield/keeper"
"github.com/elys-network/elys/x/tradeshield/types"
"github.com/stretchr/testify/require"
Expand All @@ -28,11 +29,13 @@ func TradeshieldKeeper(t testing.TB) (*keeper.Keeper, sdk.Context) {

registry := codectypes.NewInterfaceRegistry()
cdc := codec.NewProtoCodec(registry)
govAddress := sdk.AccAddress(address.Module("gov"))

k := keeper.NewKeeper(
cdc,
storeKey,
memStoreKey,
govAddress.String(),
)

ctx := sdk.NewContext(stateStore, tmproto.Header{}, false, log.NewNopLogger())
Expand Down
51 changes: 51 additions & 0 deletions x/tradeshield/client/cli/tx_update_params_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package cli_test

import (
"testing"

clitestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
"github.com/stretchr/testify/require"

"github.com/elys-network/elys/testutil/network"
"github.com/elys-network/elys/x/tradeshield/client/cli"
)

func setupNetwork(t *testing.T) *network.Network {
t.Helper()

cfg := network.DefaultConfig()
return network.New(t, cfg)
}

func TestGovUpdateParams(t *testing.T) {
net := setupNetwork(t)
ctx := net.Validators[0].ClientCtx
val := net.Validators[0]

// Use baseURL to make API HTTP requests or use val.RPCClient to make direct
// Tendermint RPC calls.
// ...

args := []string{
"--title=test",
"--summary=test",
"--metadata=test",
"--deposit=1000000uelys",
"--market-order-enabled=true",
"--stake-enabled=true",
"--process-orders-enabled=true",
"--swap-enabled=true",
"--perpetual-enabled=true",
"--reward-enabled=true",
"--leverage-enabled=true",
"--limit-process-order=10000",
"--reward-percentage=0.1",
"--margin-error=0.1",
"--minimum-deposit=1000000",
"--from=" + val.Address.String(),
"-y",
}

_, err := clitestutil.ExecTestCLICmd(ctx, cli.CmdUpdateParams(), args)
require.NoError(t, err)
}
15 changes: 9 additions & 6 deletions x/tradeshield/keeper/keeper.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,24 @@ import (

type (
Keeper struct {
cdc codec.BinaryCodec
storeKey storetypes.StoreKey
memKey storetypes.StoreKey
cdc codec.BinaryCodec
storeKey storetypes.StoreKey
memKey storetypes.StoreKey
authority string
}
)

func NewKeeper(
cdc codec.BinaryCodec,
storeKey,
memKey storetypes.StoreKey,
authority string,
) *Keeper {
return &Keeper{
cdc: cdc,
storeKey: storeKey,
memKey: memKey,
cdc: cdc,
storeKey: storeKey,
memKey: memKey,
authority: authority,
}
}

Expand Down
12 changes: 10 additions & 2 deletions x/tradeshield/keeper/msg_server_update_params.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,23 @@ package keeper
import (
"context"

errorsmod "cosmossdk.io/errors"
sdk "github.com/cosmos/cosmos-sdk/types"
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
"github.com/elys-network/elys/x/tradeshield/types"
)

func (k msgServer) UpdateParams(goCtx context.Context, msg *types.MsgUpdateParams) (*types.MsgUpdateParamsResponse, error) {
ctx := sdk.UnwrapSDKContext(goCtx)

// TODO: Handling the message
_ = ctx
if k.authority != msg.Authority {
return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, "invalid authority; expected %s, got %s", k.authority, msg.Authority)
}

// store params
if err := k.SetParams(ctx, msg.Params); err != nil {
return nil, err
}

return &types.MsgUpdateParamsResponse{}, nil
}

0 comments on commit 5a23a3a

Please sign in to comment.