-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] use stored map buffer to generate queries for search sessions #91148
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validated that mapBuffer
is now saved into panelsJson
and that the maps search session is restored when the search was done with the same state that saved with the dashboard.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…lastic#91148) * [Maps] use stored map buffer to generate queries for search sessions * getDataFilters unit test * tslint * update setQuery unit tests * only set searchSessionMapBuffer when search session isRestore * tslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…91148) (#91752) * [Maps] use stored map buffer to generate queries for search sessions * getDataFilters unit test * tslint * update setQuery unit tests * only set searchSessionMapBuffer when search session isRestore * tslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Partial fix for #90776
Elasticsearch queries for map layers contain an extent filter to limit results to those around the visible map area. This causes problems with search sessions because if the screen size changes at all, then the extent filter will not match the stored search session query and there will be a cache miss.
This PR solves this problem by storing mapBuffer in the MapEmbeddable input state so that when search sessions are used, the stored mapBuffer can be used instead of the actual map buffer based on the screen size.
This solution is not perfect and there are 2 remaining problems with this approach.