Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Maps embeddable restore doesn't work if screen size has changed #90776

Closed
lizozom opened this issue Feb 9, 2021 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated v7.12.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Feb 9, 2021

Search Sessions were integrated into maps embeddable in #89342
And I just noticed a bug with the implementation:

  1. Create a dashboard with a map
  2. Save a search session from the dashboard
  3. Change the size of the browser
  4. Restore the session from management

Expected result
The map should be restored

Current result
The map does not restore properly because the geo_bounding_box parameter has changed.

image

Ideas
I think we could try and fixate the bounding box when creating the restoreState of the dashboard.

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 Team:AppServices v7.12.0 labels Feb 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@nreese
Copy link
Contributor

nreese commented Feb 9, 2021

Chatted with @lizozom and @Dosant about possible solutions. For a short term fix, Maps can round the bounding box up to the nearest tile boundary so that small changes in panel size result in exactly the same query. Longer term fix may involve having the dashboard provide a cached panel size or aspect ratio along with the search session id.

@Dosant Dosant added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated triaged labels Feb 24, 2021
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Apr 6, 2021

#91148 introduces a padding which "snaps" the data-fetch to a fixed grid, and should accommodate most use-cases where changes in screen-size occur. Can re-open when users actually run into this in the wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated v7.12.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

5 participants