Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix time range adjustment for the swim lane causing the infinite loop update #86461

Merged
merged 5 commits into from
Dec 21, 2020
Merged

[ML] Fix time range adjustment for the swim lane causing the infinite loop update #86461

merged 5 commits into from
Dec 21, 2020

Conversation

darnautov
Copy link
Contributor

Summary

Fixes #86328

Checklist

@darnautov darnautov added :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.10.2 labels Dec 18, 2020
@darnautov darnautov self-assigned this Dec 18, 2020
@darnautov darnautov requested a review from a team as a code owner December 18, 2020 14:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

peteharverson commented Dec 18, 2020 •
edited
Loading

This looks like it has fixed the issue in #86328, but in testing this, I noticed there is an issue with the 'tooManyBuckets' warning:

image

The warning shouldn't be shown here as the chart is displaying the time range of the selected cell. I think the final check in calculateChartRange in public/application/explorer/explorer_charts/explorer_charts_container_service.js needs to have an extra condition added:

  if (
    (chartRange.min > selectedEarliestMs || chartRange.max < selectedLatestMs) &&
    chartRange.max - chartRange.min < selectedLatestMs - selectedEarliestMs
  ) {
    tooManyBuckets = true;
  }

Update: Retested and confirmed fixed by 3a948fc

peteharverson
peteharverson approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM. Just found a typo in one of the tests!

x-pack/plugins/ml/public/application/explorer/hooks/use_selected_cells.test.ts Outdated Show resolved Hide resolved
jgowdyelastic
jgowdyelastic approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.0MB 7.0MB +260.0B

Distributable file count

id before after diff
default 47142 47902 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit 7de243e into elastic:master Dec 21, 2020
@darnautov darnautov deleted the ML-86328-fix-cell-selection branch December 21, 2020 18:54
@darnautov darnautov mentioned this pull request Dec 21, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 21, 2020
@darnautov
[ML] Fix time range adjustment for the swim lane causing the infinite…
5864cc9 
… loop update (elastic#86461)

* [ML] fix swim lane time selection adjustment

* [ML] fix adjustment

* [ML] fix tooManyBuckets condition

* [ML] fix typo
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 21, 2020
@darnautov
[ML] Fix time range adjustment for the swim lane causing the infinite…
d950e1d 
… loop update (elastic#86461)

* [ML] fix swim lane time selection adjustment

* [ML] fix adjustment

* [ML] fix tooManyBuckets condition

* [ML] fix typo
This was referenced Dec 21, 2020
Merged
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 21, 2020
@darnautov
[ML] Fix time range adjustment for the swim lane causing the infinite…
3fae20e 
… loop update (elastic#86461)

* [ML] fix swim lane time selection adjustment

* [ML] fix adjustment

* [ML] fix tooManyBuckets condition

* [ML] fix typo
# Conflicts:
#	x-pack/plugins/ml/public/application/explorer/hooks/use_selected_cells.ts
#	x-pack/plugins/ml/public/application/routing/routes/explorer.tsx
darnautov added a commit that referenced this pull request Dec 21, 2020
@darnautov
[ML] Fix time range adjustment for the swim lane causing the infinite…
5575fa5 
… loop update (#86461) (#86678)

* [ML] fix swim lane time selection adjustment

* [ML] fix adjustment

* [ML] fix tooManyBuckets condition

* [ML] fix typo
darnautov added a commit that referenced this pull request Dec 21, 2020
@darnautov
[ML] Fix time range adjustment for the swim lane causing the infinite…
0baaf30 
… loop update (#86461) (#86679)

* [ML] fix swim lane time selection adjustment

* [ML] fix adjustment

* [ML] fix tooManyBuckets condition

* [ML] fix typo
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 22, 2020
@gmmorris
Merge branch 'master' into alerts/typed-action-groups
d1e98eb 
* master: (36 commits)
  update apm index pattern (elastic#86739)
  [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (elastic#85422)
  [ML] Fix alignment of values in data frame analytics results view badges (elastic#86621)
  [Visualizations] Remove charts - editor plugins cyclic dependencies (elastic#84887)
  fixing blank page (elastic#86640)
  Update dependency vega to ^5.17.1 (elastic#86715)
  [Monitoring] Convert Kibana-related server files that read from _source to typescript (elastic#86364)
  Uses @elastic/elasticsearch-canary (elastic#86398)
  [CI] Removes script previously used for Karma (elastic#86412)
  [build] Remove grunt checkPlugins task (elastic#85852)
  [build] Remove grunt docker:docs task (elastic#85848)
  [ML] Add doc link for classification AUC ROC evaluation (elastic#86660)
  [ML] Edits saved object synchronization message (elastic#86664)
  Uses the new es client in canvas usage collector's fetch methods (elastic#86668)
  [ML] Support legacy watcher URL (elastic#86661)
  [ML] Fix Single Metric Viewer y domain extending beyond the visible focus area (elastic#86655)
  Migrates search telemetry usage collector es client from legacy to new (elastic#86597)
  [Alerting] Encourage type safe usage of Alerting (elastic#86623)
  Migrates kql_telemetry usage collector es client (elastic#86585)
  [ML] Fix time range adjustment for the swim lane causing the infinite loop update (elastic#86461)
  ...
darnautov added a commit that referenced this pull request Dec 22, 2020
@darnautov
[7.10] [ML] Fix time range adjustment for the swim lane causing the i…
58d9c4a 
…nfinite loop update (#86461) (#86680)

* [ML] Fix time range adjustment for the swim lane causing the infinite loop update (#86461)

* [ML] fix swim lane time selection adjustment

* [ML] fix adjustment

* [ML] fix tooManyBuckets condition

* [ML] fix typo
# Conflicts:
#	x-pack/plugins/ml/public/application/explorer/hooks/use_selected_cells.ts
#	x-pack/plugins/ml/public/application/routing/routes/explorer.tsx

* [ML] adjust unit tests

* [ML] disable mock ts check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.2 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly explorer freezes on some jobs when clicking on the left most swimlane cells
5 participants
@darnautov @elasticmachine @peteharverson @kibanamachine @jgowdyelastic