[Visualizations] Remove charts - editor plugins cyclic dependencies #84887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
the
Feature:Visualizations
stratoula
changed the title
stratoula
added
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
5 tasks
tylersmalley
approved these changes
Dec 7, 2020
|
@elasticmachine merge upstream |
kindsun
approved these changes
Dec 8, 2020
|
@elasticmachine merge upstream |
sulemanof
approved these changes
Dec 11, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ThomThomson
approved these changes
Dec 18, 2020
|
@elasticmachine merge upstream |
flash1293
approved these changes
Dec 22, 2020
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Dec 22, 2020
…lastic#84887) * Remove charts - editor cyclic dependencies * Move translations from the charts plugin to the editor plugin * Remove the dependency from the script as it is gone * Fix types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Dec 22, 2020
…84887) (#86730) * Remove charts - editor cyclic dependencies * Move translations from the charts plugin to the editor plugin * Remove the dependency from the script as it is gone * Fix types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 22, 2020
* master: (36 commits) update apm index pattern (elastic#86739) [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (elastic#85422) [ML] Fix alignment of values in data frame analytics results view badges (elastic#86621) [Visualizations] Remove charts - editor plugins cyclic dependencies (elastic#84887) fixing blank page (elastic#86640) Update dependency vega to ^5.17.1 (elastic#86715) [Monitoring] Convert Kibana-related server files that read from _source to typescript (elastic#86364) Uses @elastic/elasticsearch-canary (elastic#86398) [CI] Removes script previously used for Karma (elastic#86412) [build] Remove grunt checkPlugins task (elastic#85852) [build] Remove grunt docker:docs task (elastic#85848) [ML] Add doc link for classification AUC ROC evaluation (elastic#86660) [ML] Edits saved object synchronization message (elastic#86664) Uses the new es client in canvas usage collector's fetch methods (elastic#86668) [ML] Support legacy watcher URL (elastic#86661) [ML] Fix Single Metric Viewer y domain extending beyond the visible focus area (elastic#86655) Migrates search telemetry usage collector es client from legacy to new (elastic#86597) [Alerting] Encourage type safe usage of Alerting (elastic#86623) Migrates kql_telemetry usage collector es client (elastic#86585) [ML] Fix time range adjustment for the swim lane causing the infinite loop update (elastic#86461) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #84750
Removes circular dependencies between
chartsandvis_default_editorplugins.To be more specific, we decided to move the editor shared components that are used on the Options tab and currently live on the
chartsplugin to thevis_default_editorplugin. We are doing this not only to remove the circular dependency between these two plugins but also the editor is the plugin that should provde these components to the other plugins.I have also moved the translations from charts to the vis_default_editor plugin.
The dependencies that were removed based on the
node scripts/find_plugins_with_circular_deps --debugscript are: