[Enterprise Search] Add Workplace Search side navigation #74894

scottybollinger · 2020-08-12T19:21:12Z

Summary

closes https://github.com/elastic/workplace-search-team/issues/1190

EDIT: After discussions with product, it was decided that the navigation should be hidden and the code merge incrementally but not exposed until a later date.

This implements a navigation component that Workplace Search can use for their sidebar navigation:

Currently all links except the existing 'overview' pages simply link out externally/in a new tab to Workplace Search.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility
Tested in dark mode

x-pack/plugins/enterprise_search/public/applications/shared/version.ts

scottybollinger · 2020-08-12T19:38:31Z

@jonasll @brianearwood does it make sense to remove the "Launch Workplace Search" button with this PR since all top-level functionality is linkable from the sidebar?

scottybollinger · 2020-08-12T20:03:16Z

@elasticmachine merge upstream

brianearwood · 2020-08-12T20:08:38Z

Thanks, Scotty! The navigation looks good 👍

does it make sense to remove the "Launch Workplace Search" button with this PR since all top-level functionality is linkable from the sidebar?

It makes sense to me. Now that all of the navigation is in place, the "Launch Workplace Search" button makes me feel like I'm not already in Workplace Search, which is confusing. I'd remove it.

scottybollinger · 2020-08-12T20:32:25Z

@elasticmachine merge upstream

No longer needed since we have all top-level app links in Kibana as a part of this PR

Tests were failing after removing component: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67797/execution/node/382/log/

jonasll · 2020-08-12T23:12:51Z

Is this a 7.10 merge target? If so, my answer will differ on whether or not it makes sense to drop it.

scottybollinger · 2020-08-13T00:39:56Z

Is this a 7.10 merge target? If so, my answer will differ on whether or not it makes sense to drop it.

Yes, the plan is to merge this into 7.10

jonasll · 2020-08-13T16:03:28Z

If that's the case, I worry a little bit about the jumpy nature of the experience if we don't make every link in the sidebar followed by an "external link icon". If I click on one of those navigation icons, I definitely do not expect to be taken to an entirely new dashboard with its own navigation. Is App Search following a similar path? @johnbarrierwilson

cee-chen

Code LGTM Scotty! I'll wait to approve for now until we figure out any product/design changes or requirements from Jonas etc. FWIW, I hadn't heard of any requirement from @johnbarrierwilson or @daveyholler on adding an icon to indicate an external vs non-external URL, but definitely appreciate that UX point and will defer to y'all on preference.

Also as a quick heads up Scotty - if Workplace Search has any nested/indented navigation coming up, I do have a dev branch that adds the styling and logic for that behavior - let me know if you need it sooner rather than later!

cee-chen · 2020-08-13T19:06:42Z

x-pack/plugins/translations/translations/ja-JP.json

@@ -6873,7 +6873,6 @@
    "xpack.enterpriseSearch.workplaceSearch.overviewOnboardingUsersCard.description": "検索できるように、同僚をこの組織に招待します。",
    "xpack.enterpriseSearch.workplaceSearch.overviewOnboardingUsersCard.title": "ユーザーと招待",
    "xpack.enterpriseSearch.workplaceSearch.overviewUsersCard.title": "検索できるように、同僚を招待しました。",
-    "xpack.enterpriseSearch.workplaceSearch.productCta": "Workplace Searchの起動",
    "xpack.enterpriseSearch.workplaceSearch.productName": "Workplace Search",


Oh wow, I hadn't realized we already received translations for our plugin!!!! 🎉 🎉 🎉

daveyholler · 2020-08-13T19:20:31Z

I don't disagree about the jumpy nature of links opening externally, but I'm also a little hesitant to add the external link icon to every link. I think, visually, it'll get pretty busy. Especially in table views with a stack of links that open in a new window. Opinion is strongly voiced and lightly held.

cee-chen · 2020-08-13T19:28:59Z

Maybe we can circle back to how many views/links we've ported over about 2 weeks before 7.10 feature freeze and see how many outgoing/external links we have left at that point? And use those numbers to determine then if we want to add 'new window' icons?

This reverts commit ba05351.

For now, the route for groups was added to avoid having comment out the code. Will add the groups component in a future PR

Since there is no nav, the padding was missing and the view looked off. Reverting to the 7.9, centered column view

Was causing tests to fail

kibanamachine · 2020-08-14T20:28:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d416fa8

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
enterpriseSearch	196	+5	191

async chunks size

id	value	diff	baseline
enterpriseSearch	359.6KB	+51.9KB	307.7KB

History

💔 Build #68204 failed d0b39a6
💚 Build #67804 succeeded ba05351
💔 Build #67797 failed ae43e4d
💔 Build #67792 failed 3731d39
💔 Build #67785 failed de6aa1b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (24 commits) [ML] Functional tests - skip regression and classification tests [Ingest Manager] fix removing ingest pipelines from elasticsearch (elastic#75092) move tests for placeholder indices to setup (elastic#75096) [jest] temporarily extend default test timeout (elastic#75118) [cli] remove reference to removed --optimize flag (elastic#75083) skip flaky suite (elastic#75044) Adding /etc/rc.d/init.d/functions to the init script when present to … (elastic#22985) [jenkins] add pipeline for hourly security solution cypress tests (elastic#75087) [Reporting/Flaky Test] Skip test for paging list of reports (elastic#75075) remove .kbn-optimizer-cache upload (elastic#75086) skip flaky suite (elastic#74814) Actions add proxy support (elastic#74289) [ILM] TS conversion of Edit policy components (elastic#74747) [Resolver] simulator tests select elements directly instead of using descendant selectors. (elastic#75058) [Enterprise Search] Add Workplace Search side navigation (elastic#74894) [Security solution] Sourcerer: Kibana index pattern selector for security views (elastic#74706) [Logs UI] Remove apollo deps from log link-to routes (elastic#74502) [Maps] add map configurations to docker list (elastic#75035) [functional test][saved objects] update tests for additional copy saved objects to space (elastic#74907) Make the alerts plugin support generics (elastic#72716) ...

* Add routes * Add version for use in doc link * Set up basic router layout + WorkplaceSearchNav * Update views to account for Layout * Move version to common folder * Fix version path * Remove product button No longer needed since we have all top-level app links in Kibana as a part of this PR * You know, for search * Remove comment * Remove unused i18n properties from JSON Tests were failing after removing component: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67797/execution/node/382/log/ * Revert button and i18n copy removal This reverts commit ba05351. * Move Overview out of layout to hide nav For now, the route for groups was added to avoid having comment out the code. Will add the groups component in a future PR * Revert layout changes to Overview Since there is no nav, the padding was missing and the view looked off. Reverting to the 7.9, centered column view * Remove extra Overview component Was causing tests to fail * Revert error state to use EuiPage Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…5191) * Add routes * Add version for use in doc link * Set up basic router layout + WorkplaceSearchNav * Update views to account for Layout * Move version to common folder * Fix version path * Remove product button No longer needed since we have all top-level app links in Kibana as a part of this PR * You know, for search * Remove comment * Remove unused i18n properties from JSON Tests were failing after removing component: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67797/execution/node/382/log/ * Revert button and i18n copy removal This reverts commit ba05351. * Move Overview out of layout to hide nav For now, the route for groups was added to avoid having comment out the code. Will add the groups component in a future PR * Revert layout changes to Overview Since there is no nav, the padding was missing and the view looked off. Reverting to the 7.9, centered column view * Remove extra Overview component Was causing tests to fail * Revert error state to use EuiPage Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

scottybollinger added 4 commits August 12, 2020 13:49

Add routes

fe91582

Add version for use in doc link

822d0b3

Set up basic router layout + WorkplaceSearchNav

1a531c4

Update views to account for Layout

ede9872

cee-chen reviewed Aug 12, 2020

View reviewed changes

x-pack/plugins/enterprise_search/public/applications/shared/version.ts Outdated Show resolved Hide resolved

Move version to common folder

0da8efc

scottybollinger added Feature:Plugins release_note:enhancement v7.10.0 labels Aug 12, 2020

scottybollinger marked this pull request as ready for review August 12, 2020 20:03

scottybollinger requested a review from cee-chen August 12, 2020 20:03

Merge branch 'master' into ws-nav

de6aa1b

elasticmachine and others added 6 commits August 12, 2020 14:32

Merge branch 'master' into ws-nav

3731d39

Fix version path

dde4e07

Remove product button

02e00b5

No longer needed since we have all top-level app links in Kibana as a part of this PR

You know, for search

d7b0ec0

Remove comment

ae43e4d

Remove unused i18n properties from JSON

ba05351

Tests were failing after removing component: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67797/execution/node/382/log/

cee-chen reviewed Aug 13, 2020

View reviewed changes

scottybollinger added 2 commits August 14, 2020 12:26

Revert button and i18n copy removal

cd17432

This reverts commit ba05351.

Move Overview out of layout to hide nav

b3ba9ed

For now, the route for groups was added to avoid having comment out the code. Will add the groups component in a future PR

Revert layout changes to Overview

d0b39a6

Since there is no nav, the padding was missing and the view looked off. Reverting to the 7.9, centered column view

scottybollinger requested a review from cee-chen August 14, 2020 17:59

scottybollinger added 2 commits August 14, 2020 13:22

Remove extra Overview component

7b9658e

Was causing tests to fail

Revert error state to use EuiPage

d416fa8

cee-chen approved these changes Aug 14, 2020

View reviewed changes

scottybollinger merged commit ac04e05 into elastic:master Aug 14, 2020

scottybollinger deleted the ws-nav branch August 14, 2020 20:28

scottybollinger mentioned this pull request Aug 17, 2020

[7.x] [Enterprise Search] Add Workplace Search side navigation (#74894) #75191

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enterprise Search] Add Workplace Search side navigation #74894

[Enterprise Search] Add Workplace Search side navigation #74894

scottybollinger commented Aug 12, 2020 •

edited

Loading

scottybollinger commented Aug 12, 2020 •

edited

Loading

scottybollinger commented Aug 12, 2020

brianearwood commented Aug 12, 2020

scottybollinger commented Aug 12, 2020

jonasll commented Aug 12, 2020

scottybollinger commented Aug 13, 2020

jonasll commented Aug 13, 2020

cee-chen left a comment •

edited

Loading

cee-chen Aug 13, 2020

daveyholler commented Aug 13, 2020

cee-chen commented Aug 13, 2020

kibanamachine commented Aug 14, 2020

[Enterprise Search] Add Workplace Search side navigation #74894

[Enterprise Search] Add Workplace Search side navigation #74894

Conversation

scottybollinger commented Aug 12, 2020 • edited Loading

Summary

closes https://github.com/elastic/workplace-search-team/issues/1190

Checklist

scottybollinger commented Aug 12, 2020 • edited Loading

scottybollinger commented Aug 12, 2020

brianearwood commented Aug 12, 2020

scottybollinger commented Aug 12, 2020

jonasll commented Aug 12, 2020

scottybollinger commented Aug 13, 2020

jonasll commented Aug 13, 2020

cee-chen left a comment • edited Loading

Choose a reason for hiding this comment

cee-chen Aug 13, 2020

Choose a reason for hiding this comment

daveyholler commented Aug 13, 2020

cee-chen commented Aug 13, 2020

kibanamachine commented Aug 14, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

History

scottybollinger commented Aug 12, 2020 •

edited

Loading

scottybollinger commented Aug 12, 2020 •

edited

Loading

cee-chen left a comment •

edited

Loading