Adding /etc/rc.d/init.d/functions to the init script when present to … #22985

aaronmaxlevy · 2018-09-13T01:46:18Z

…improve integration with systemd on systemd-based distros. See #22255

…improve integration with systemd on systemd-based distros. See elastic#22255

elasticmachine · 2018-09-13T01:46:20Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

kobelb · 2018-09-18T14:59:34Z

Jenkins, test this

elasticmachine · 2018-09-18T16:34:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

mistic

Thanks for the PR @aaronmaxlevy. This looks fine to me. However, Isn't /lib/lsb/init-functions the equivalent for deb and also /etc/rc.status mandatory for the openSuse RPM compatibility (maybe you have some thoughts here @jbudz )?

aaronmaxlevy · 2018-10-03T04:04:56Z

@mistic Fair point. I was only thinking about this from the RHEL standpoint but I'll add support for Debian and SUSE also.

aaronmaxlevy · 2018-10-03T04:49:05Z

@mistic I've added support for Debian and SUSE as requested. Let me know your thoughts when you get a chance :) Thanks!

mistic

@aaronmaxlevy thanks for help! LGTM right now.

aaronmaxlevy · 2018-10-07T23:13:40Z

@jbudz @tylersmalley Forgive my ignorance as I've not contributed to Kibana before, but I'm assuming both of you would need to approve this in order for it to get merged (in addition to the approval from @mistic ) ? If so, what is the general turnaround time for getting those reviews done?

Thanks!

aaronmaxlevy · 2018-11-28T23:46:22Z

@tylersmalley @jbudz any updates on this? Thanks!

elasticmachine · 2018-11-28T23:47:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

aaronmaxlevy · 2018-11-28T23:50:54Z

Hmm, the Jenkins build of this failed with "FATAL: java.io.IOException: java.nio.file.NoSuchFileException: /var/lib/jenkins/workspace/elastic+kibana+pull-request/kibana/.ci/jobs.yml"

That doesn't seem like something related to this PR unless I am missing something? Would it be possible to get it to attempt a rebuild?

Updating fork

…improve integration with systemd on systemd-based distros. See elastic#22255

…ana into add_sysv_init_functions

aaronmaxlevy · 2018-11-29T00:37:06Z

@tylersmalley @jbudz looks like the issue was that you guys updated your CI stuff since I created this PR. I've since rebased my PR off of master and so ".ci/jobs.yml" should now be present and the Jenkins build should theoretically pass now.

aaronmaxlevy · 2018-12-21T04:52:45Z

Any updates on this?

mistic · 2019-06-28T01:32:22Z

@aaronmaxlevy could you please merge the last master on that branch so we can move on with that PR?

elasticmachine · 2019-06-28T01:53:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…ctions

aaronmaxlevy · 2019-09-26T03:13:41Z

@mistic I merged latest to my branch as requested.

elasticmachine · 2019-09-26T04:36:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

aaronmaxlevy · 2020-08-05T07:24:27Z

@mistic and @jbudz is there any update on this? This has been open for two years at this point, which is a long time for a change that is this simple.

mistic · 2020-08-05T14:47:24Z

@elasticmachine merge upstream

mistic · 2020-08-05T14:58:26Z

Jenkins, test this

aaronmaxlevy · 2020-08-05T17:43:43Z

@mistic Can this PR be merged now, since tests have passed?

mistic · 2020-08-12T19:19:20Z

@elasticmachine merge upstream

aaronmaxlevy · 2020-08-13T14:01:30Z

@mistic What else is needed before this can be merged (if anything)? Thanks!

mistic · 2020-08-14T18:36:05Z

@aaronmaxlevy I'll let the CI run for a last time and then merge it

mistic · 2020-08-14T19:39:06Z

@elasticmachine merge upstream

mistic · 2020-08-14T21:13:58Z

@elasticmachine merge upstream

mistic · 2020-08-14T21:14:25Z

Jenkins test this

kibanamachine · 2020-08-14T23:07:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4620b02

Build metrics

✅ unchanged

History

💔 Build #68232 failed c4ab81f
💚 Build #68212 succeeded 160573d
💚 Build #66661 succeeded a890585

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic · 2020-08-15T00:31:14Z

7.x: 096d65f

elastic#22985) * Adding /etc/rc.d/init.d/functions to the init script when present to improve integration with systemd on systemd-based distros. See elastic#22255 * Adding SysV Init Functions for Debian and SUSE distros * Adding /etc/rc.d/init.d/functions to the init script when present to improve integration with systemd on systemd-based distros. See elastic#22255 * Adding SysV Init Functions for Debian and SUSE distros * docs(NA): include a comment to explain the change Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>

#22985) (#75111) * Adding /etc/rc.d/init.d/functions to the init script when present to improve integration with systemd on systemd-based distros. See #22255 * Adding SysV Init Functions for Debian and SUSE distros * Adding /etc/rc.d/init.d/functions to the init script when present to improve integration with systemd on systemd-based distros. See #22255 * Adding SysV Init Functions for Debian and SUSE distros * docs(NA): include a comment to explain the change Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Aaron Levy <aaronmaxlevy@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (24 commits) [ML] Functional tests - skip regression and classification tests [Ingest Manager] fix removing ingest pipelines from elasticsearch (elastic#75092) move tests for placeholder indices to setup (elastic#75096) [jest] temporarily extend default test timeout (elastic#75118) [cli] remove reference to removed --optimize flag (elastic#75083) skip flaky suite (elastic#75044) Adding /etc/rc.d/init.d/functions to the init script when present to … (elastic#22985) [jenkins] add pipeline for hourly security solution cypress tests (elastic#75087) [Reporting/Flaky Test] Skip test for paging list of reports (elastic#75075) remove .kbn-optimizer-cache upload (elastic#75086) skip flaky suite (elastic#74814) Actions add proxy support (elastic#74289) [ILM] TS conversion of Edit policy components (elastic#74747) [Resolver] simulator tests select elements directly instead of using descendant selectors. (elastic#75058) [Enterprise Search] Add Workplace Search side navigation (elastic#74894) [Security solution] Sourcerer: Kibana index pattern selector for security views (elastic#74706) [Logs UI] Remove apollo deps from log link-to routes (elastic#74502) [Maps] add map configurations to docker list (elastic#75035) [functional test][saved objects] update tests for additional copy saved objects to space (elastic#74907) Make the alerts plugin support generics (elastic#72716) ...

Adding /etc/rc.d/init.d/functions to the init script when present to …

357aef6

…improve integration with systemd on systemd-based distros. See elastic#22255

kobelb requested review from jbudz and tylersmalley September 18, 2018 14:59

Bargs added the Team:Operations Team label for Operations Team label Sep 25, 2018

mistic reviewed Oct 3, 2018

View reviewed changes

Adding SysV Init Functions for Debian and SUSE distros

6e971de

mistic approved these changes Oct 4, 2018

View reviewed changes

aaronmaxlevy added 4 commits November 28, 2018 16:30

Merge pull request #1 from elastic/master

dd2853d

Updating fork

Adding /etc/rc.d/init.d/functions to the init script when present to …

521841f

…improve integration with systemd on systemd-based distros. See elastic#22255

Adding SysV Init Functions for Debian and SUSE distros

91c2e3f

Merge branch 'add_sysv_init_functions' of github.com:aaronmaxlevy/kib…

80e3880

…ana into add_sysv_init_functions

Merge remote-tracking branch 'upstream/master' into add_sysv_init_fun…

11aeb64

…ctions

aaronmaxlevy requested a review from a team as a code owner September 26, 2019 03:12

mistic added release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes labels Sep 30, 2019

Merge branch 'master' into add_sysv_init_functions

a890585

mistic added v7.10.0 v7.9.1 and removed v7.5.0 labels Aug 5, 2020

mistic removed the v7.9.1 label Aug 5, 2020

jbudz approved these changes Aug 6, 2020

View reviewed changes

Merge branch 'master' into add_sysv_init_functions

160573d

This comment has been minimized.

Sign in to view

Merge branch 'master' into add_sysv_init_functions

8be2bde

This comment has been minimized.

Sign in to view

docs(NA): include a comment to explain the change

c4ab81f

This comment has been minimized.

Sign in to view

Merge branch 'master' into add_sysv_init_functions

4620b02

mistic merged commit 9760498 into elastic:master Aug 15, 2020

mistic mentioned this pull request Aug 15, 2020

[7.x] Adding /etc/rc.d/init.d/functions to the init script when present to … (#22985) #75111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding /etc/rc.d/init.d/functions to the init script when present to … #22985

Adding /etc/rc.d/init.d/functions to the init script when present to … #22985

aaronmaxlevy commented Sep 13, 2018

elasticmachine commented Sep 13, 2018

kobelb commented Sep 18, 2018

elasticmachine commented Sep 18, 2018

mistic left a comment

aaronmaxlevy commented Oct 3, 2018

aaronmaxlevy commented Oct 3, 2018

mistic left a comment

aaronmaxlevy commented Oct 7, 2018

aaronmaxlevy commented Nov 28, 2018

elasticmachine commented Nov 28, 2018

aaronmaxlevy commented Nov 28, 2018

aaronmaxlevy commented Nov 29, 2018

aaronmaxlevy commented Dec 21, 2018

mistic commented Jun 28, 2019

elasticmachine commented Jun 28, 2019

aaronmaxlevy commented Sep 26, 2019

elasticmachine commented Sep 26, 2019

aaronmaxlevy commented Aug 5, 2020

mistic commented Aug 5, 2020

mistic commented Aug 5, 2020

aaronmaxlevy commented Aug 5, 2020

mistic commented Aug 12, 2020

aaronmaxlevy commented Aug 13, 2020

This comment has been minimized.

mistic commented Aug 14, 2020

mistic commented Aug 14, 2020

This comment has been minimized.

This comment has been minimized.

mistic commented Aug 14, 2020

mistic commented Aug 14, 2020

kibanamachine commented Aug 14, 2020

mistic commented Aug 15, 2020 •

edited

Loading

Adding /etc/rc.d/init.d/functions to the init script when present to … #22985

Adding /etc/rc.d/init.d/functions to the init script when present to … #22985

Conversation

aaronmaxlevy commented Sep 13, 2018

elasticmachine commented Sep 13, 2018

kobelb commented Sep 18, 2018

elasticmachine commented Sep 18, 2018

💚 Build Succeeded

mistic left a comment

Choose a reason for hiding this comment

aaronmaxlevy commented Oct 3, 2018

aaronmaxlevy commented Oct 3, 2018

mistic left a comment

Choose a reason for hiding this comment

aaronmaxlevy commented Oct 7, 2018

aaronmaxlevy commented Nov 28, 2018

elasticmachine commented Nov 28, 2018

💔 Build Failed

aaronmaxlevy commented Nov 28, 2018

aaronmaxlevy commented Nov 29, 2018

aaronmaxlevy commented Dec 21, 2018

mistic commented Jun 28, 2019

elasticmachine commented Jun 28, 2019

💔 Build Failed

aaronmaxlevy commented Sep 26, 2019

elasticmachine commented Sep 26, 2019

💚 Build Succeeded

aaronmaxlevy commented Aug 5, 2020

mistic commented Aug 5, 2020

mistic commented Aug 5, 2020

aaronmaxlevy commented Aug 5, 2020

mistic commented Aug 12, 2020

aaronmaxlevy commented Aug 13, 2020

This comment has been minimized.

mistic commented Aug 14, 2020

mistic commented Aug 14, 2020

This comment has been minimized.

This comment has been minimized.

mistic commented Aug 14, 2020

mistic commented Aug 14, 2020

kibanamachine commented Aug 14, 2020

💚 Build Succeeded

Build metrics

History

mistic commented Aug 15, 2020 • edited Loading

mistic commented Aug 15, 2020 •

edited

Loading