[Metrics UI] Add overrides to Snapshot API to support alert previews #68125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
force-pushed
the
inventory-alert-charts
branch
from
144e83a
to
46fb7bf
Compare
simianhacker
changed the title
simianhacker
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Zacqary
approved these changes
Jun 3, 2020
x-pack/plugins/infra/server/lib/snapshot/create_timerange_with_interval.ts
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 4, 2020
…ms-column * 'master' of github.com:elastic/kibana: (63 commits) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) Update documentation/examples of deprecated namespaceAgnostic field (elastic#68039) [DOCS] Updates Canvas docs with new menus (elastic#66061) chore(NA): avoids imports of server or public code into common (elastic#67231) [SIEM] Fix GetOneTimeline graphql type (elastic#68137) skip flaky suite (elastic#67838) [Uptime] Add loading message for monitor list no items (elastic#67378) [Ingest Manager] Update indexing strategy docs to use dataset.* (elastic#68068) [Ingest Manager] Fix datasource validation for streams without vars (elastic#67950) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/index.ts # x-pack/plugins/index_management/__jest__/client_integration/home.test.ts # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 4, 2020
* master: (26 commits) [Console]remove completion for type for filter queries and aggs (elastic#68103) [ML] Transforms: Filter aggregation support (elastic#67591) [ES UI Shared] Monaco XJSON (elastic#67485) [Index Management] Add data streams functionality to indices tab (elastic#67940) [Discover] Fix renaming of saved search not displayed in breadcrumb (elastic#67577) [SECURITY] Rename siem plugin to security_solution (elastic#67902) [Uptime] Fix Telemetry Api flaky test (elastic#67358) [Data plugin] Add configuration property to enable / disable autocomplete (elastic#67847) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) ...
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jun 4, 2020
…lastic#68125) * [Metrics UI] Add overrides to Snapshot API to support alert previews * Renaming tests from infra to metrics_ui; renaming waffle to snapshot; adding tests for overrides * removing limit and afterKey; removing extra interval * Setting the minimum value for lookbackSize
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jun 4, 2020
…lastic#68125) * [Metrics UI] Add overrides to Snapshot API to support alert previews * Renaming tests from infra to metrics_ui; renaming waffle to snapshot; adding tests for overrides * removing limit and afterKey; removing extra interval * Setting the minimum value for lookbackSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds overrides to the Snapshot API to support the alert previews and charts. This adds a few new options to the
SnapshotRequest:timerange.lookbackSize– The snapshot API returns data for the last5buckets by default. This option will override the default and allow the developer to control the number of buckets. We plan to use this for the the charts on the Inventory Alerts so we can give the user a preview of the last 20 buckets.timerange.ignoreLookback– This options ignores the lookback and returns the entire timerange.timerange.forceInterval– By default the snapshot API tries to lookup themetricset.periodfor each field used in the aggregations. This options allows us to override that feature and force the interval specified in thetimerangeobject.includeTimeseries– This option will add thetimeseriesobject, which usesMetricsExplorerSeriesas the type, to themetricobject on theSnapshotNodeobjectsThis PR also renames the integration tests from
x-pack/test/api_integration/infratox-pack/test/api_integration/metrics_uiandwaffletosnapshot.Checklist
Delete any items that are not applicable to this PR.