Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data plugin] Add configuration property to enable / disable autocomplete #67847

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 1, 2020

Closed: #67841

Summary

[Data plugin] Add configuration property to enable / disable autocomplete

Dev docs

[Data plugin] Autocomplete
Two new configuration properties were added to enable/disable autocomplete functionality

data.autocomplete.valueSuggestions.enabled: true | false
data.autocomplete.querySuggestions.enabled: true | false

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp marked this pull request as ready for review June 1, 2020 14:24
@alexwizp alexwizp requested a review from a team as a code owner June 1, 2020 14:24
@alexwizp
Copy link
Contributor Author

alexwizp commented Jun 3, 2020

@elasticmachine merge upstream

@rayafratkina
Copy link
Contributor

It seems we removed this setting by mistake in 7.7, so I think this is a bug fix. In fact I think it's even worthy of patching 7.7

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@alexwizp alexwizp merged commit 6195f3e into elastic:master Jun 4, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
…lete (elastic#67847)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
…lete (elastic#67847)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
…lete (elastic#67847)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/plugin.ts
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
…lete (elastic#67847)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
…lete (elastic#67847)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/plugin.ts
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
…lete (elastic#67847)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
alexwizp added a commit that referenced this pull request Jun 4, 2020
…lete (#67847) (#68222)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Jun 4, 2020
…lete (#67847) (#68224)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/plugin.ts
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
alexwizp added a commit that referenced this pull request Jun 4, 2020
…lete (#67847) (#68223)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 4, 2020
* master: (26 commits)
  [Console]remove completion for type for filter queries and aggs (elastic#68103)
  [ML] Transforms: Filter aggregation support (elastic#67591)
  [ES UI Shared] Monaco XJSON (elastic#67485)
  [Index Management] Add data streams functionality to indices tab (elastic#67940)
  [Discover] Fix renaming of saved search not displayed in breadcrumb (elastic#67577)
  [SECURITY] Rename siem plugin to security_solution (elastic#67902)
  [Uptime] Fix Telemetry Api flaky test (elastic#67358)
  [Data plugin] Add configuration property to enable / disable autocomplete (elastic#67847)
  remove scripts. prettire update has been done (elastic#68130)
  Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198)
  [apm] docs: add deployment annotation example (elastic#67408)
  [ML] Extend population preview chart to show actual and typical value (elastic#67569)
  Refactor index management client integration tests for scalability (elastic#67917)
  Add generator function that creates multiple alerts (elastic#67713)
  chore(NA): remove config arg from os packages (elastic#67871)
  [Reporting] Move code out of Legacy (elastic#67904)
  [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125)
  [Security] [Cases] Manage timeline UI API (elastic#67719)
  [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234)
  Fix code coverage for jest, upload merged reports (elastic#68149)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data plugin] Add configuration property to enable / disable autocomplete
6 participants