Use renamed @graphql-codegen/cli instead of graphql-code-generator

[watson]

The dev-dependency module graphql-code-generator has been deprecated and new development continues under the name @graphql-codegen/cli. The old version is no longer maintained.

An upgrade-guide has been published for upgrading from graphql-code-generator to @graphql-codegen/cli: https://graphql-code-generator.com/docs/migration/from-0-18

[watson]

CI fails the "Check licenses" check with the following errors:

succ All production dependency licenses are allowed
ERROR Non-conforming licenses:
        @apollographql/graphql-language-service-interface
          version: 2.0.2
          all licenses: Custom: https://github.com/graphql/graphql-language-service
          invalid licenses: Custom: https://github.com/graphql/graphql-language-service
          path: node_modules/apollo-language-server/node_modules/@apollographql/graphql-language-service-interface
        @apollographql/graphql-language-service-parser
          version: 2.0.2
          all licenses: Custom: http://graphql.org/
          invalid licenses: Custom: http://graphql.org/
          path: node_modules/apollo-language-server/node_modules/@apollographql/graphql-language-service-parser
        @apollographql/graphql-language-service-types
          version: 2.0.2
          all licenses: Custom: https://flowtype.org/
          invalid licenses: Custom: https://flowtype.org/
          path: node_modules/apollo-language-server/node_modules/@apollographql/graphql-language-service-types
        @apollographql/graphql-language-service-utils
          version: 2.0.2
          all licenses: Custom: https://github.com/graphql/graphql-language-service
          invalid licenses: Custom: https://github.com/graphql/graphql-language-service
          path: node_modules/apollo-language-server/node_modules/@apollographql/graphql-language-service-utils

The license issue is also being discussed by others here: apollographql/apollo-tooling#1553

[spalger]

When dependencies have a license that can't be properly parsed we can override the setting via https://github.com/elastic/kibana/blob/e60f7d62edaacd969ec8ff0971117f3687e18617/src/dev/license_checker/config.ts#L79-L107

Looked at a couple of these and it seems they could be hard-coded to MIT

[watson]

Due to apollo-link being upgraded to v1.2.14 in this PR, we now get a new TypeScript error (from scripts/type_check.js) inside of said module:

ERROR x-pack/test failed
      node_modules/apollo-link/lib/types.d.ts:5:18 - error TS2430: Interface 'ExecutionResult<TData>' incorrectly extends interface 'ExecutionResult<ExecutionResultDataDefault>'.
        Types of property 'data' are incompatible.
          Type 'TData | null | undefined' is not assignable to type 'ExecutionResultDataDefault | undefined'.
            Type 'null' is not assignable to type 'ExecutionResultDataDefault | undefined'.

      5 export interface ExecutionResult<TData = {
                         ~~~~~~~

If I pin apollo-link to v1.2.13, the error goes away.

The change that causes this is this one: apollographql/apollo-link#1263

It appears that this is because the new module isn't compatible with GraphQL 13 which we are using. However, using Yarn resolutions to force apollo-link to be v1.2.13, isn't that maintainable, so I don't like it, but unless we can get apollo-link to release a new version that re-adds support for GraphQL 13, I don't see any other way short of upgrading our GraphQL version to v15.

Update: Found a way to get around this without using Yarn resolutions by modifying yarn.lock manually to ensure we used versions of apollo-link more in line with what's already in master

[watson]

@elasticmachine merge upstream

[spalger]

Operations: LGTM

[watson]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: e01d87d

History

• 💚 Build #43847 succeeded b83749b
• 💔 Build #43814 failed c196e80
• 💚 Build #43742 succeeded b0af869
• 💔 Build #43728 failed b537826
• 💔 Build #43360 failed 033333e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jasonrhodes]

infra (logs/metrics) changes LGTM -> I don't think we use that script anymore, I'll ping the team about removing it if that's the case. Thanks!

[FrankHassanabad]

When running from SIEM we got errors when I did:

cd ~/projects/kibana/x-pack/plugins/siem
node scripts/generate_types_from_graphql.js

And then when I ran a type check:

cd ~/projects/kibana
node scripts/type_check.js --project x-pack/tsconfig.json

And got a lot of errors (I won't post here unless you cannot reproduce)

Once those are fixed and any new different generated types are part of this PR, I will give it a test and if everything during runtime looks good I will give it a LGTM.

[watson]

GraphQL is scheduled to be removed soon (tip from @XavierM), so I think I'll just close this PR, as the GraphQL code generator is being removed at the same time.