Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo for graphql-language-service-interface #1553

Closed
OliverCole opened this issue Sep 30, 2019 · 4 comments
Closed

Repo for graphql-language-service-interface #1553

OliverCole opened this issue Sep 30, 2019 · 4 comments

Comments

@OliverCole
Copy link

Hi - where is the repo for @apollographql/graphql-language-service-interface? The repo linked from NPM is 404.

This package, along with parser, types and utils are published on NPM without a license, which means I can't use them.

Could this be resolved?

@abernix
Copy link
Member

abernix commented Jan 6, 2020

The packages you're referring to were once forked from an upstream repository located at https://github.com/graphql/graphql-language-service/.

Today, as noted on on that project's README, that repository has been rolled into the GraphiQL IDE monorepo project and now lives in https://github.com/graphql/graphiql/tree/master/packages/, where newer versions of it are licensed under the MIT license.

Apollo created the fork (and published them to npm within our own @apollographql/ namespace) to remove a dependency on graphql-config and graphql-import which were problematic since they brought in hard-coded versions of graphql, which caused problems for our tooling offerings, like the Apollo VSCode extension.

When Apollo originally forked those packages to apply the aforementioned changes, those packages were under the terms of the Facebook license (This all happened prior to Facebook broadly relicensing GraphQL-related over to the MIT license).

We no longer maintain the fork of the package, but the branch point would have been this commit in the upstream repository. You can view the license terms at that point in history via this license file. And again, our only changes to it were the removal of the aforementioned dependencies and the associated code (which was not important to our functionality).

So the packages are licensed, but it's not as clear as it once was. Does this work for you?

@abernix abernix closed this as completed Jan 6, 2020
@OliverCole
Copy link
Author

Appreciate the response - to clarify, you're saying that apollo@2.21.2 depends on forks of those libraries which are no longer maintained? So this issue can't/won't be fixed?

The issue from my end is an automated analysis of the licensing, which depends on either the LICENSE file in the git repo linked from package.json, or the license field as published on the NPM registry. The apollo@2.21.2 package is fine, but when it spiders the dependencies, these packages fail to find either - and so I can't use the entire stack, which is unfortunate.

@redmundas
Copy link

we have exactly the same problem, these packages were reported:

wouldn't it be possible for you to update to packages from https://github.com/graphql/graphiql/tree/master/packages/ ?

@smoak
Copy link

smoak commented Jun 16, 2020

I agree. I think this should be re-opened. Newer versions of apollo (e.g. 2.28.3) still depend on these forked packages (with the facebook license). This means apollo et all is unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants