Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use POST instead of implicit GET #45903

Merged
merged 2 commits into from
Sep 17, 2019
Merged

[APM] Use POST instead of implicit GET #45903

merged 2 commits into from
Sep 17, 2019

Conversation

sorenlouv
Copy link
Member

Closes #45890

@sorenlouv sorenlouv requested a review from a team as a code owner September 17, 2019 15:23
@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Sep 17, 2019
@sorenlouv sorenlouv mentioned this pull request Sep 17, 2019
Merged
ogupte
ogupte approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sorenlouv
Copy link
Member Author

retest

@sorenlouv
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv sorenlouv merged commit 238ddd8 into elastic:master Sep 17, 2019
@sorenlouv sorenlouv deleted the fix-apm-agent-config-endpoint-http-method branch September 17, 2019 18:26
@sorenlouv sorenlouv mentioned this pull request Sep 17, 2019
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Sep 17, 2019
@sorenlouv
[APM] Use POST instead of implicit GET (elastic#45903)
90ae91a
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
@rylnd
Merge branch 'master' into new-search-layout
41683c0 
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
@rylnd
Merge branch 'master' into new-search-layout
f27d4c8 
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
@sorenlouv sorenlouv mentioned this pull request Sep 18, 2019
Closed
sorenlouv added a commit that referenced this pull request Sep 18, 2019
@sorenlouv
[APM] Use POST instead of implicit GET (#45903) (#45930)
08690f4
@sorenlouv sorenlouv mentioned this pull request Sep 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Agent configuration search endpoint should be of method POST instead of GET
3 participants
@sorenlouv @elasticmachine @ogupte