Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] upgrade elastic charts library - v12.0.2 #45853

Merged
merged 1 commit into from
Sep 17, 2019
Merged

[SIEM] upgrade elastic charts library - v12.0.2 #45853

merged 1 commit into from
Sep 17, 2019

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Sep 16, 2019 •
edited
Loading

Summary

  1. Ugrade @elastic/charts to v12.0.2
  2. Remove the setTimeout I added for waiting the state change
    onBrushEnd should be called after setState is completed elastic-charts#360

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem

@elasticmachine
Copy link
Contributor

💔 Build Failed

@angorayc
Copy link
Contributor Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort mentioned this pull request Sep 17, 2019
Merged
1 task
@nickofthyme nickofthyme mentioned this pull request Sep 17, 2019
Closed
2 tasks
nickofthyme
nickofthyme approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angorayc angorayc merged commit a70e0f4 into elastic:master Sep 17, 2019
@angorayc angorayc mentioned this pull request Sep 17, 2019
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Sep 17, 2019
@angorayc
remove setTimeoue for state change (elastic#45853)
e57e163
@angorayc angorayc mentioned this pull request Sep 17, 2019
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Sep 17, 2019
@angorayc
remove setTimeoue for state change (elastic#45853)
a7eb72d
angorayc added a commit that referenced this pull request Sep 17, 2019
@angorayc
remove setTimeoue for state change (#45853) (#45894)
0ed2cea
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
@rylnd
Merge branch 'master' into new-search-layout
41683c0 
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
@rylnd
Merge branch 'master' into new-search-layout
f27d4c8 
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
angorayc added a commit that referenced this pull request Sep 18, 2019
@angorayc
remove setTimeoue for state change (#45853) (#45893)
5ddc355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:SIEM v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angorayc @elasticmachine @nickofthyme