New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Localization #30881

Merged

thomasneirynck merged 91 commits into elastic:master from thomasneirynck:maps/localize

Mar 6, 2019

Contributor

thomasneirynck commented Feb 12, 2019 •

edited

Loading

Closes #23408.

localize content
fix tests


          initial commit

557123d

thomasneirynck added WIP Project:i18n [Deprecated-Use Team:Presentation]Team:Geo v8.0.0 v7.2.0 v6.7.1 v7.0.1 labels

Contributor

elasticmachine commented Feb 12, 2019

Pinging @elastic/kibana-gis


          add telemetry file

6ee5a8e

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Contributor

elasticmachine commented Feb 13, 2019

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

thomasneirynck added 5 commits

February 14, 2019 11:03


          Merge branch 'master' into maps/localize

d8b9ece


          translate routes file

a83d80e


          localize feature registration

4f88465


          remove dead code path

3ab2b0f


          fix edit

b9f6af2

Contributor

spalger commented Feb 14, 2019

retest


          localize es parsing

538f533

Contributor

elasticmachine commented Feb 14, 2019

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck added 8 commits

February 14, 2019 17:12


          remove dead code

27b964b


          style names

46e896a


          typos

1650e40


          register maps plugin

a883115


          replace with string

3834b06


          localize xyz source

11a241f

wms

e701185


          source details

d0bae44

Contributor

elasticmachine commented Feb 15, 2019

💔 Build Failed

continuous-integration/kibana-ci/pull-request


          feedback

d1506bb

thomasneirynck requested a review from nreese

March 6, 2019 20:22

nreese reviewed

View reviewed changes

x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/create_source_editor.js Outdated Show resolved Hide resolved

nreese reviewed

View reviewed changes

x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/create_source_editor.js Outdated Show resolved Hide resolved

nreese reviewed

View reviewed changes

x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/es_geo_grid_source.js Show resolved Hide resolved


          update snaps

f259247

nreese reviewed

View reviewed changes

x-pack/plugins/maps/public/shared/layers/sources/es_search_source/create_source_editor.js

                     >
                       <SingleFieldSelect
-                        placeholder="Select geo field"
+                        placeholder={i18n.translate('xpack.maps.source.esSearch.selectLabel', {

Contributor

nreese Mar 6, 2019

LEts change id to xpack.maps.source.esSearch.geofieldPlaceholder

nreese reviewed

View reviewed changes

x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js Outdated Show resolved Hide resolved

nreese reviewed

View reviewed changes

x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js Outdated Show resolved Hide resolved

thomasneirynck added 3 commits

March 6, 2019 15:47


          feedback (2)

87ef04b


          use function

3e28e7e


           no need to internationalize url

09851c0

Contributor

elasticmachine commented Mar 6, 2019

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

nreese approved these changes

View reviewed changes

Contributor

nreese left a comment

Great job bringing this one across the finish line. Looks great

lgtm with green CI
code review

Contributor Author

thomasneirynck commented Mar 6, 2019

jenkins, test this

Contributor

elasticmachine commented Mar 6, 2019

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

thomasneirynck merged commit 5e5a49a into elastic:master

thomasneirynck mentioned this pull request

[7.x] [Maps] Localization (#30881) #32601

Merged

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request


          [Maps] Localization (elastic#30881)

f92dbfd

Localize Maps-app UX with Kibana's i18n framework.

Contributor Author

thomasneirynck commented Mar 6, 2019

Backports:

7.x: [7.x] [Maps] Localization (#30881) #32601
7.0: hold off until 7.0 release
6.7: hold off until 6.7 release

thomasneirynck added a commit that referenced this pull request


          [Maps] Localization (#30881) (#32601)

5ae417d

Localize Maps-app UX with Kibana's i18n framework.

PhilippBaranovskiy pushed a commit to PhilippBaranovskiy/kibana that referenced this pull request


          [Maps] Localization (elastic#30881)

d1d26db

Localize Maps-app UX with Kibana's i18n framework.

thomasneirynck mentioned this pull request

[7.0] [Maps] Localization (#30881) #33312

Merged

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request


          [Maps] Localization (elastic#30881)

9122f17

Localize Maps-app UX with Kibana's i18n framework.

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request


          [Maps] Localization (elastic#30881)

551a1b3

Localize Maps-app UX with Kibana's i18n framework.

thomasneirynck added a commit that referenced this pull request


          [7.0] [Maps] Localization (#30881) (#33312)

1daea2d

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request


          [7.0] [Maps] Localization (elastic#30881) (elastic#33312)

c895375

thomasneirynck added a commit that referenced this pull request


          [6.7] [Maps] Localization (#30881) (#33312) (#33318)

843af31

Backports #33312

This was referenced Apr 1, 2019

[Maps] Map breadcrumb is missing from 6.7.0/6.7.1 #34258

Closed

[Maps][6.7] fix breadcrumbs in Maps application #34270

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Deprecated-Use Team:Presentation]Team:Geo Project:i18n v6.7.1 v7.0.1 v7.2.0 v8.0.0