Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Build localization framework into GIS app #23408

Closed
rayafratkina opened this issue Sep 21, 2018 · 4 comments · Fixed by #30881
Closed

[Maps] Build localization framework into GIS app #23408

rayafratkina opened this issue Sep 21, 2018 · 4 comments · Fixed by #30881
Assignees
Labels

Comments

@rayafratkina
Copy link
Contributor

Describe the feature:
The new GIS app should include localization capabilities to allow us to translate it later.
It should also utilize locale-appropriate map data per #23407

Describe a specific use case for the feature:

cc @elastic/kibana-gis @jinmu03

@jinmu03
Copy link
Contributor

jinmu03 commented Sep 21, 2018

@epixa @azasypkin

@azasypkin
Copy link
Member

Hey @elastic/kibana-gis ,

What is exactly the scope of this work? Is it related to the text labels we create inside Kibana GIS app/plugin itself or the ones that you receive from the 3rd-party server? If the former, feel free to start with Guide-level explanation and Technical-level explanation from #17201 and let us know if you have any questions or doubts.

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Sep 25, 2018

The scope is two-fold here:

  • integration of EMS-localization: This is the piece that we do not have a handle on. It is basically ensuring EMS publishes multi-language layer files, and that this is consumed correctly in the GIS-app. It is blocked by Provide a way to select locale for map layer data #23407.
  • integration of Kibana-localization: this is the more conventional effort. Ensuring that our UX (buttons, toasts, ...) are multi-language. For this we can piggy-back directly on the current Kibana work (cf. your link RFC: Kibana Internationalization #17201 is a good start for this)

@thomasneirynck thomasneirynck added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Oct 10, 2018
@thomasneirynck thomasneirynck changed the title Build localization framework into GIS app [Maps] Build localization framework into GIS app Jan 7, 2019
@thomasneirynck thomasneirynck self-assigned this Jan 9, 2019
@thomasneirynck
Copy link
Contributor

After internal discussion, it's unlikely this will make 6.7 and 7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants