Wrap leadfoot elements #26406
Merged
Wrap leadfoot elements #26406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
2 times, most recently
from
2b4e72d
to
9d9c3f1
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
3 times, most recently
from
e9e6756
to
8312a1a
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
from
8312a1a
to
c5d734e
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
from
c5d734e
to
985f0f0
Compare
💔 Build Failed |
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
2 times, most recently
from
f096988
to
2fd7aee
Compare
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
from
2fd7aee
to
b4dfed8
Compare
💔 Build Failed |
cuff-links
previously approved these changes
Dec 4, 2018
|
LGTM |
…dfoot-element-wrapper
spalger
force-pushed
the
implement/leadfoot-element-wrapper
branch
from
b4dfed8
to
3ff31c1
Compare
💔 Build Failed |
dmlemeshko
previously approved these changes
Dec 4, 2018
There was a problem hiding this comment.
This element wrapper API looks nice and the most of it will be easy for migration to WebElement API
💔 Build Failed |
💔 Build Failed |
spalger
dismissed stale reviews from dmlemeshko and cuff-links
need to get tests passing first
💚 Build Succeeded |
spalger
commented
Dec 5, 2018
| * | ||
| * @return {Promise<void>} | ||
| */ | ||
| async moveMouseTo(...args) { |
There was a problem hiding this comment.
Can we list the argument here explicitly and document then in the doc block too?
added 2 commits
December 5, 2018 11:19
💔 Build Failed |
|
Test is flaky, failed 3 times on master recently, will disable. Jenkins, test this please |
💔 Build Failed |
LeeDr
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
LGTM
There's just one unrelated test failure in the last Jenkins job;
X-Pack Phantom API Reporting Tests.x-pack/test/reporting/api/bwc_existing_indexes·js.phantom BWC report generation into existing indexes existing 6_2 index multiple jobs posted (from (TEST-X-Pack Phantom API Reporting Tests.xml))
…dfoot-element-wrapper
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 6, 2018
* [ftr] wrap all elements so we can swap out leadfoot without disturbing tests * save * [visualize/pie_chart] fix chart legend locator * [services/leadfoot_element_wrapper] add getTagName function * [services/browser] adjust moveMouseTo function * [leadfoot/element] remove old args, document new ones
spalger
pushed a commit
that referenced
this pull request
Dec 6, 2018
* Wrap leadfoot elements (#26406) * [ftr] wrap all elements so we can swap out leadfoot without disturbing tests * save * [visualize/pie_chart] fix chart legend locator * [services/leadfoot_element_wrapper] add getTagName function * [services/browser] adjust moveMouseTo function * [leadfoot/element] remove old args, document new ones * [leadfootElementWrapper] add getSpecAttribute() method
|
6.x/6.6: b51987b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26394
Wrap elements that come from leadfoot so we can expose a limited version of the Leadfoot API and adapt it for a different library like selenium webdriver.