[ftr] wrap remote in browser service #26394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/remove-references-to-remote
branch
7 times, most recently
from
d0840a4
to
7442ab5
Compare
spalger
force-pushed
the
fix/remove-references-to-remote
branch
2 times, most recently
from
17510de
to
c7cdf25
Compare
💚 Build Succeeded |
added 10 commits
November 29, 2018 01:07
spalger
force-pushed
the
fix/remove-references-to-remote
branch
from
789722b
to
1b85788
Compare
💚 Build Succeeded |
|
Pinging @elastic/kibana-platform |
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
cuff-links
approved these changes
Nov 29, 2018
dmlemeshko
approved these changes
Nov 29, 2018
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 29, 2018
* [pageObjects/common] remove unused runScript method * [pageObjects/common] remove almost unused doesCssSelectorExist method * [pageObjects/graph] convert to use find/testSubjects services * [pageObjects/discover] refactor out remote service * [pageObjects/pointSeries] refactor out remote service * [pageObjects/monitoring] refactor out remote service * [ftr] refactor uses of remote to use browser or find * [ftr/services/remote] wrap remote with browser service * [pageObjects/security] refactor out uses of remote * [ftr/services/browser] isolate element calls to find * [ftr] rename remote service to __leadfoot__ * [ftr/leadfoot] cleanup some renames in find, keep names in other tests
This was referenced Nov 29, 2018
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 29, 2018
* [pageObjects/common] remove unused runScript method * [pageObjects/common] remove almost unused doesCssSelectorExist method * [pageObjects/graph] convert to use find/testSubjects services * [pageObjects/discover] refactor out remote service * [pageObjects/pointSeries] refactor out remote service * [pageObjects/monitoring] refactor out remote service * [ftr] refactor uses of remote to use browser or find * [ftr/services/remote] wrap remote with browser service * [pageObjects/security] refactor out uses of remote * [ftr/services/browser] isolate element calls to find * [ftr] rename remote service to __leadfoot__ * [ftr/leadfoot] cleanup some renames in find, keep names in other tests
spalger
pushed a commit
that referenced
this pull request
Nov 30, 2018
|
6.x: 3abe125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to decouple us from leadfoot a little more and make it easier to move away from the library this refactors several page objects to use a wrapper service
browser, which exposes a subset of the methods fromremotewhich we should be able to port to whatever library we like. We've also renamed theremoteservice to__leadfoot__in an effort to discourage users from using it instead of thebrowserorfindservices.