Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Removes redundant index.asciidoc files #19192

Merged
merged 4 commits into from
May 18, 2018
Merged

[DOCS] Removes redundant index.asciidoc files #19192

merged 4 commits into from
May 18, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 17, 2018

Related to #19156 and elastic/docs#354

The navigation tree for the Kibana User Guide had been split into many smaller index-shared*.asciidoc files to accommodate the fact that X-Pack-specific content was being pulled from other repos. This is no longer necessary, therefore we can go back to a single index.asciidoc file.

@lcawl lcawl requested review from debadair and gchaps May 17, 2018 23:31
This was referenced May 17, 2018
Closed
Merged
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

gchaps
gchaps approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit d11b5aa into elastic:master May 18, 2018
@lcawl lcawl deleted the lcawley-ossbuild branch May 18, 2018 18:50
lcawl added a commit that referenced this pull request May 18, 2018
@lcawl
[DOCS] Removes redundant index.asciidoc files (#19192)
7913f07
lcawl added a commit that referenced this pull request May 18, 2018
@lcawl
[DOCS] Removes redundant index.asciidoc files (#19192)
d42ecf4
rhoboat pushed a commit that referenced this pull request May 18, 2018
@archanid
Revert "[DOCS] Removes redundant index.asciidoc files (#19192)"
78e8a0a 
This reverts commit d11b5aa.
rhoboat pushed a commit that referenced this pull request May 18, 2018
@archanid
Revert "Option to run kibana from build for CI" (#19224)
eaa4960 
* Revert "[DOCS] Removes redundant index.asciidoc files (#19192)"

This reverts commit d11b5aa.

* Revert "[typescript] add typescript support for the server and browser (#19104)"

This reverts commit c611206.

* Revert "Option to run kibana from build for CI (#19125)"

This reverts commit 5969860.
rhoboat pushed a commit that referenced this pull request May 18, 2018
@archanid
Revert "Option to run kibana from build for CI" (#19224)
05640a3 
* Revert "[DOCS] Removes redundant index.asciidoc files (#19192)"

This reverts commit d11b5aa.

* Revert "[typescript] add typescript support for the server and browser (#19104)"

This reverts commit c611206.

* Revert "Option to run kibana from build for CI (#19125)"

This reverts commit 5969860.
rhoboat pushed a commit that referenced this pull request May 18, 2018
@archanid
Revert "Option to run kibana from build for CI" (#19224)
ccefa30 
* Revert "[DOCS] Removes redundant index.asciidoc files (#19192)"

This reverts commit d11b5aa.

* Revert "[typescript] add typescript support for the server and browser (#19104)"

This reverts commit c611206.

* Revert "Option to run kibana from build for CI (#19125)"

This reverts commit 5969860.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@debadair debadair Awaiting requested review from debadair

Assignees
No one assigned
Labels
Team:Docs v6.3.1 v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcawl @elasticmachine @gchaps