Create grunt task to generate parsers from peg files #17069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
Jenkins, test this |
💚 Build Succeeded |
spalger
reviewed
Mar 9, 2018
tasks/peg.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| module.exports = function (grunt) { | |||
| const config = { | |||
| peg: { | |||
There was a problem hiding this comment.
This should go in tasks/config/peg.js
spalger
reviewed
Mar 9, 2018
tasks/peg.js
Outdated
| } | ||
| } | ||
| }, | ||
| watch: { |
There was a problem hiding this comment.
This should go in tasks/config/watch.js
spalger
suggested changes
Mar 9, 2018
Bargs
suggested changes
Mar 12, 2018
There was a problem hiding this comment.
Other than Spencer's comments the tasks lgtm.
Could you add a comment to the top of the .peg files explaining that these tasks need to be run before changes will take effect?
It would be cool to tie this into the optimizer and build process at some point so the generation would happen automatically, but I don't think it's really necessary in this PR.
💚 Build Succeeded |
Bargs
approved these changes
Mar 21, 2018
|
LGTM |
💚 Build Succeeded |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 21, 2018
* Create grunt task to generate parsers from peg files * Leave comment * Move grunt config to config/
|
6.x (6.3.0): 1224648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #17049, we are using the generated parsing modules instead of dynamically creating the parser for PEG grammars.
Creating the PEG modules is an annoying task to run manually, especially with regards to keeping track of which options to use. This PR creates two grunt tasks: One for generating the parsing modules from the grammar (
grunt peg) and another to watch the .peg files and then run the previous task (grunt watch:peg).I had originally tried using the webpack loader for PEG but found out that this resulted in the same problem that was the reason we created #17049 to begin with... i.e. reporting would break presumably since Phantom would choke on the .peg files.